From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 1/2] ALSA: firewire-lib: cache next data_block_counter after probing tracepoints event for IR context Date: Fri, 28 Jun 2019 10:50:21 +0200 Message-ID: References: <20190628055331.1427-1-o-takashi@sakamocchi.jp> <20190628055331.1427-2-o-takashi@sakamocchi.jp> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BCC4FF80768 for ; Fri, 28 Jun 2019 10:50:21 +0200 (CEST) In-Reply-To: <20190628055331.1427-2-o-takashi@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Takashi Sakamoto Cc: alsa-devel@alsa-project.org, clemens@ladisch.de List-Id: alsa-devel@alsa-project.org On Fri, 28 Jun 2019 07:53:30 +0200, Takashi Sakamoto wrote: > > For debugging purpose, ALSA IEC 61883-1/6 engine has tracepoints event. > In current implementation, next data block counter is stored as current > data block counter before probing the event for IR isoc context. It's not > good to check current packet parameter. > > This commit changes to assign the next data block counter after probing > the event. > > Besides, Fireworks devices has a quirk to transfer isoc packet with > data block counter for the last data block. For this quirk, the > assignment is done before calling data block processing layer. > > Signed-off-by: Takashi Sakamoto Thanks, applied now. Takashi