From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ASoC: rsnd: stop all working stream when .remove Date: Tue, 05 Sep 2017 16:08:31 +0200 Message-ID: References: <87d17akgqr.wl%kuninori.morimoto.gx@renesas.com> <20170905140400.kiz4hlksdz25f7cu@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 1BBE526683B for ; Tue, 5 Sep 2017 16:08:32 +0200 (CEST) In-Reply-To: <20170905140400.kiz4hlksdz25f7cu@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Linux-ALSA , Simon , Kuninori Morimoto List-Id: alsa-devel@alsa-project.org On Tue, 05 Sep 2017 16:04:00 +0200, Mark Brown wrote: > > On Tue, Sep 05, 2017 at 01:35:58PM +0200, Takashi Iwai wrote: > > > So my idea is something like below (totally untested): call > > snd_card_disconnect_sync() at the remove call of each component at the > > beginning. > > That assures stopping all pending operations and syncs with the file > > releases. For ASoC, we may want to wrap it with ASoC structs, but you > > can have an idea by this patch. > > I'd say that in ASoC we'd have the call to this in the core rather than > wrapping it, I'd expect the first thing the drivers do is to unregister > the component. Yes, that makes sense. Takashi