From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v2] ALSA: hda - verify pin:cvt connection
	on preparing a stream for Intel HDMI codec
Date: Fri, 28 Mar 2014 16:54:25 +0100
Message-ID: <s5hr45m2ua6.wl%tiwai@suse.de>
References: <c8336299f64f1fda9e0d0488fbef5e90a67e287b.1395135128.git.mengdong.lin@intel.com>
 <ae7e1c58c756e7149bc8b93f648bc56fd7af73d1.1395291484.git.mengdong.lin@intel.com>
 <s5hzjklbckf.wl%tiwai@suse.de> <533531D5.3000504@canonical.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id C4139265506
 for <alsa-devel@alsa-project.org>; Fri, 28 Mar 2014 16:54:26 +0100 (CET)
In-Reply-To: <533531D5.3000504@canonical.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: David Henningsson <david.henningsson@canonical.com>
Cc: mengdong.lin@intel.com, alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Fri, 28 Mar 2014 09:24:53 +0100,
David Henningsson wrote:
> 
> On 03/20/2014 07:37 AM, Takashi Iwai wrote:
> > At Thu, 20 Mar 2014 13:01:06 +0800,
> > mengdong.lin@intel.com wrote:
> >>
> >> From: Mengdong Lin <mengdong.lin@intel.com>
> >>
> >> This is a temporary fix for some Intel HDMI codecs to avoid no sound output for
> >> a resuming playback after S3.
> >>
> >> After S3, the audio driver restores pin:cvt connection selections by
> >> snd_hda_codec_resume_cache(). However this can happen before the gfx side is
> >> ready and such connect selection is overlooked by HW. After gfx is ready, the
> >> pins make the default selection again. And this will cause multiple pins share
> >> a same convertor and mute control will affect each other. Thus a resumed audio
> >> playback become silent after S3.
> >>
> >> This patch verifies pin:cvt connection on preparing a stream, to assure the pin
> >> selects the right convetor and an assigned convertor is not shared by other
> >> unused pins. Apply this fix-up on Haswell, Broadwell and Valleyview (Baytrail).
> >>
> >> We need this temporary fix before a reliable software communication channel is
> >> established between audio and gfx, to sync audio/gfx operations.
> >>
> >> Signed-off-by: Mengdong Lin <mengdong.lin@intel.com>
> > 
> > Thanks, applied.
> 
> Hi,
> 
> Any reason this commit isn't sent to stable? Looks like a candidate.

No particular reason from my side.  Feel free to ask for stable once
when the patch hits to Linus tree.


thanks,

Takashi