From: Takashi Iwai <tiwai@suse.de>
To: Ben Dooks <ben-alsa@fluff.org>
Cc: alsa-devel@alsa-project.org, Ben Dooks <ben-linux@fluff.org>
Subject: Re: AUDIO: Split WM8750 IO routines from core for SPI
Date: Mon, 23 Jun 2008 14:28:36 +0200 [thread overview]
Message-ID: <s5hr6ao2v4b.wl%tiwai@suse.de> (raw)
In-Reply-To: <20080623115406.920274505@fluff.org.uk>
At Mon, 23 Jun 2008 12:54:07 +0100,
Ben Dooks wrote:
>
> Add SPI support to the WM8750 ASoC codec by splitting
> the I2C out of the WM8750 codec and adding an standard
> SPI driver to the system.
>
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
>
> Index: linux-2.6.26-rc4-quilt3/sound/soc/codecs/Kconfig
> ===================================================================
> --- linux-2.6.26-rc4-quilt3.orig/sound/soc/codecs/Kconfig 2008-05-26 23:17:51.000000000 +0100
> +++ linux-2.6.26-rc4-quilt3/sound/soc/codecs/Kconfig 2008-06-02 15:26:21.000000000 +0100
> @@ -10,6 +10,16 @@ config SND_SOC_WM8750
> tristate
> depends on SND_SOC
>
> +config SND_SOC_WM8750_I2C
> + tristate
> + select SND_SOC_WM8750
> + depends on SND_SOC && (CONFIG_I2C || CONFIG_I2C_MODULE)
This is wrong in Kconfig. Should be
depends on SND_SOC && CONFIG_I2C
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-2.6.26-rc4-quilt3/sound/soc/codecs/wm8750-i2c.c 2008-06-02 15:42:19.000000000 +0100
> +#include <sound/driver.h>
This header file is obsoleted.
Takashi
next prev parent reply other threads:[~2008-06-23 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 11:54 AUDIO: Split WM8750 IO routines from core for SPI Ben Dooks
2008-06-23 12:28 ` Takashi Iwai [this message]
2008-06-23 14:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr6ao2v4b.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=ben-alsa@fluff.org \
--cc=ben-linux@fluff.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox