From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 2/2] ALSA sound driver for the AT73C213 DAC
	using Atmel SSC driver
Date: Mon, 16 Jul 2007 17:32:52 +0200
Message-ID: <s5hr6n8xt23.wl%tiwai@suse.de>
References: <11845952993023-git-send-email-hcegtvedt@atmel.com>
	<11845952991232-git-send-email-hcegtvedt@atmel.com>
	<s5hwsx0xu7h.wl%tiwai@suse.de>
	<20070716172746.777afe0e@dhcp-255-175.norway.atmel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id 189E41037FD
	for <alsa-devel@alsa-project.org>;
	Mon, 16 Jul 2007 17:32:53 +0200 (CEST)
In-Reply-To: <20070716172746.777afe0e@dhcp-255-175.norway.atmel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: alsa-devel@alsa-project.org, kernel@avr32linux.org, Hans-Christian Egtvedt <hcegtvedt@atmel.com>
List-Id: alsa-devel@alsa-project.org

At Mon, 16 Jul 2007 17:27:46 +0200,
Haavard Skinnemoen wrote:
> 
> On Mon, 16 Jul 2007 17:08:02 +0200
> Takashi Iwai <tiwai@suse.de> wrote:
> 
> > > +struct at73c213_board_info {
> > > +	int		ssc_id;
> > > +	struct clk	*dac_clk;
> > > +	char		shortname[32];
> > > +};
> > > +
> > > +#endif /* __LINUX_SPI_AT73C213_H */  
> > 
> > Any reason to put this into include/linux?  Are (or will be) there
> > users of this except for ALSA driver?
> 
> This struct contains information about how the sound chip is hooked up
> on the board, so it needs to be defined in a place where the platform
> code can easily find it. Since it's not arch specific, it doesn't
> belong under <asm/...> so <linux/spi/...> seems like a logical choice.
> 
> This patch shows how it's meant to be used:
> 
> http://avr32linux.org/archives/kernel/2007-July/000124.html

Fair enough, then I have no objection about that.


Takashi