From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [2.6 patch] ALSA PCI drivers: misc cleanups Date: Mon, 22 Nov 2004 18:28:34 +0100 Message-ID: References: <20041121235855.GI13254@stusta.de> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from Cantor.suse.de (ns.suse.de [195.135.220.2]) by alsa.alsa-project.org (ALSA's E-mail Delivery System) with ESMTP id 73FCE2A5 for ; Mon, 22 Nov 2004 18:28:34 +0100 (MET) In-Reply-To: <20041121235855.GI13254@stusta.de> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Adrian Bunk Cc: perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org At Mon, 22 Nov 2004 00:58:55 +0100, Adrian Bunk wrote: > > The patch below does the following cleanups under sound/pci/ : > - cs46xx/dsp_spos_scb_lib.c: cs46xx_dsp_create_filter_scb > - cs46xx/dsp_spos_scb_lib.c: cs46xx_dsp_create_output_snoop_scb I'd rather like to keep them with #if 0. These functions will be needed when someone extends the DSP code. > --- linux-2.6.10-rc2-mm2-full/sound/pci/ac97/ac97_local.h.old 2004-11-22 00:00:07.000000000 +0100 > +++ linux-2.6.10-rc2-mm2-full/sound/pci/ac97/ac97_local.h 2004-11-22 00:00:27.000000000 +0100 > @@ -45,9 +45,6 @@ > int snd_ac97_page_get_single(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol); > int snd_ac97_page_put_single(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol); > int snd_ac97_try_bit(ac97_t * ac97, int reg, int bit); > -int snd_ac97_remove_ctl(ac97_t *ac97, const char *name, const char *suffix); > -int snd_ac97_rename_ctl(ac97_t *ac97, const char *src, const char *dst, const char *suffix); > -int snd_ac97_swap_ctl(ac97_t *ac97, const char *s1, const char *s2, const char *suffix); They are intentionally non-static to allow ac97_patch.c functions to access them (in future). Please keep them so. Otherwise the patch looks fine. Thanks! Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/