From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBE39C433EF for ; Fri, 4 Mar 2022 08:52:22 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BD39718C5; Fri, 4 Mar 2022 09:51:30 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BD39718C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646383940; bh=a3Wl5Wt21qNRcTkkVDgPqnpY2YMRLkaf7gonM+DZPC4=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dCIi8pmyi9bSIZHGFmw7DoBARAcVjQcGAWDNTUmHHmC+5sgLnKpsOqMmZxWqmAAqR cUcO15eEYMzqnDlQ9bd0WsWw+lgMXWulmX3pRTPlulkiJrgszJ+aW7gGUYGqlnIQp4 IiSWFOhaiQPttCdgX4ApfpDsEcBCgf49cpJRH9Tc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 595EEF80139; Fri, 4 Mar 2022 09:51:30 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 95A64F801EC; Fri, 4 Mar 2022 09:51:28 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3041BF800F0 for ; Fri, 4 Mar 2022 09:51:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3041BF800F0 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="CJjoqG1K"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="nGdOjxJi" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id A4C8E21136; Fri, 4 Mar 2022 08:51:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646383885; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=slqWuDwOoH/Q5XlOhkioyiGZ0ilW0OBu5hUs4LHxwxA=; b=CJjoqG1Kh563odELWTDZkXLiqEDm+WjyISHd5xwzsNAhGqqw/VajH3xLlE9tlJxkcLbASy ReDQ5Jayk8E+eQfPurL4RYjuWWXJm+lEhQPdHFVW96qv4olsmKsHXsbbP38hziUezy3BCc HiCbWHBhoIqdWwJ5myzr10lydClipoY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646383885; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=slqWuDwOoH/Q5XlOhkioyiGZ0ilW0OBu5hUs4LHxwxA=; b=nGdOjxJiB8ElSvqgH5B1ZDOIKsxBc3K6YbRTDuh+qkY2fD/s98hl908MXPlc1WKYs2oj1s X7HLpiTPpHQZntCA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 877EAA3B83; Fri, 4 Mar 2022 08:51:25 +0000 (UTC) Date: Fri, 04 Mar 2022 09:51:25 +0100 Message-ID: From: Takashi Iwai To: Colin Ian King Subject: Re: [PATCH] ALSA: echoaudio: remove redundant assignment to variable bytes In-Reply-To: <20220302170728.1094633-1-colin.i.king@gmail.com> References: <20220302170728.1094633-1-colin.i.king@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, llvm@lists.linux.dev, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 02 Mar 2022 18:07:28 +0100, Colin Ian King wrote: > > The variable bytes is being assigned a value that is never read, it > is being re-assigned inside a following if block. The assignment is > redundant and can be removed. > > Cleans up clang scan build warning: > sound/pci/echoaudio/midi.c:211:9: warning: Although the value stored > to 'bytes' is used in the enclosing expression, the value is never > actually read from 'bytes' [deadcode.DeadStores] > > Signed-off-by: Colin Ian King Thanks, applied. Takashi