From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B47D5C433EF for ; Wed, 2 Mar 2022 08:28:47 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0F00817BC; Wed, 2 Mar 2022 09:27:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0F00817BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646209725; bh=iwO3XpkyCuJJjQP+dNH80pi4XMJQtHxprcUHIKhv7HU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=UG/mm8N15GuffXUEDZ/8QrkXiJlttgOkHYvNUTRuY9PtlDyNGWL1WqfSzlOphZTnQ vlUvIK5XvIGU1DWHE7Sa/py0hd0wxoCdSw8TFoQEjBQS49hqPzVo8QZOTCf3x9jpxC uv0UCfQmnomTjq4GvGleY7FwXdPkmWGUN5RdO4Qk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9E921F80054; Wed, 2 Mar 2022 09:27:54 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B5727F801D5; Wed, 2 Mar 2022 09:27:53 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AC90DF80054 for ; Wed, 2 Mar 2022 09:27:46 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AC90DF80054 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="vDMBA6VN"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="2eissv3E" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 3D77A218EE; Wed, 2 Mar 2022 08:27:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646209666; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9TSNZrBpMR+dD20Bm8WKUFJxKv90bww4RaWEH7qCn6E=; b=vDMBA6VN228hGxDmm4+6hI/zXP5PucvtznNszbtFx+r1zlfTWAjzsBSAEkQQKSjaRTgrN9 2yI1ubP9jcE0vQwN0nQjXKP720KLsPoOiUkmUlnfShp0LUsNe9DS0cHstw8yLJBoQMiqne ehKo0tf1a+Sqd9NQA8vm2ymLCMDObfc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646209666; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9TSNZrBpMR+dD20Bm8WKUFJxKv90bww4RaWEH7qCn6E=; b=2eissv3EzPZGWaDipG/hR9vy55/Tv2Dhw65glMJwAGemow5y6iG+53f2gHk54jMzG6rmbh VunqKtNcIDmHnNBw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 23217A3B84; Wed, 2 Mar 2022 08:27:45 +0000 (UTC) Date: Wed, 02 Mar 2022 09:27:45 +0100 Message-ID: From: Takashi Iwai To: Zhen Ni Subject: Re: [PATCH] ALSA: intel_hdmi: Fix reference to PCM buffer address In-Reply-To: <20220302074241.30469-1-nizhen@uniontech.com> References: <20220302074241.30469-1-nizhen@uniontech.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 02 Mar 2022 08:42:41 +0100, Zhen Ni wrote: > > PCM buffers might be allocated dynamically when the buffer > preallocation failed or a larger buffer is requested, and it's not > guaranteed that substream->dma_buffer points to the actually used > buffer. The driver needs to refer to substream->runtime->dma_addr > instead for the buffer address. > > Signed-off-by: Zhen Ni Thanks, applied now with Cc-to-stable. I guess the had_pcm_mmap() can be dropped completely and replaced with the standard mmap helper, as what we really want is rather wc. But it can be done for 5.18. Takashi