From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5665EC4363A for ; Mon, 26 Oct 2020 19:30:43 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 578132085B for ; Mon, 26 Oct 2020 19:30:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Iz5xmpSm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 578132085B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CEAA816AD; Mon, 26 Oct 2020 20:29:48 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CEAA816AD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1603740638; bh=mKXwla1Hx2ixSQQXCAYdP4xXvJmzWVKPk8YJPe5lYO4=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Iz5xmpSmroqIwpX3VOywsMJCGnmLWX9XNld2Whxg93IVvanG2yO4J6efh7ATA4lNW fULCz8SinH3roQWeChMFE2CO5TFPFNOf4ALbRJEk/yESiGSY1yy5A3sKDCKebgXIMQ ljzf/LLziTOgu+9guAjVr/ze3sepzPXVxb4F/guo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2C9EAF801D8; Mon, 26 Oct 2020 20:29:48 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C97C5F80212; Mon, 26 Oct 2020 20:29:45 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A95EBF800CC for ; Mon, 26 Oct 2020 20:29:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A95EBF800CC X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E56F7AE2B; Mon, 26 Oct 2020 19:29:37 +0000 (UTC) Date: Mon, 26 Oct 2020 20:29:37 +0100 Message-ID: From: Takashi Iwai To: Arnd Bergmann Subject: Re: [PATCH] ALSA: make snd_kcontrol_new name a normal string In-Reply-To: References: <20201026165715.3723704-1-arnd@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: "linux-kernel@vger.kernel.org" , ALSA Development Mailing List , "Gustavo A. R. Silva" , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 26 Oct 2020 20:03:39 +0100, Arnd Bergmann wrote: > > On Mon, Oct 26, 2020 at 6:03 PM Takashi Iwai wrote: > > On Mon, 26 Oct 2020 17:52:18 +0100, > > Arnd Bergmann wrote: > > > > > > From: Arnd Bergmann > > > > > > When building with W=2, there are lots of warnings about the > > > snd_kcontrol_new name field being an array of 'unsigned char' > > > but initialized to a string: > > > > > > include/sound/soc.h:93:48: warning: pointer targets in initialization of 'const unsigned char *' from 'char *' differ in signedness [-Wpointer-sign] > > > > > > Make it a regular 'char *' to avoid flooding the build log with this. > > > > > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > > Signed-off-by: Arnd Bergmann > > > > I'm fine to apply this, but I thought we agreed to ignore pointer > > signedness intentionally? There are lots of such places and we were > > fed up in the past when gcc complained a lot about those... > > I'm only sending fixes for the ones in headers that get included in > a lot of places. There are good reasons for building being able to > build specific drivers or directories with W=2, but it's less helpful > if there are many identical warnings. OK, now I applied the patch. Thanks! Takashi