From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A6DC433E0 for ; Tue, 9 Jun 2020 08:06:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14A0820812 for ; Tue, 9 Jun 2020 08:06:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="K8+7Cr2P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14A0820812 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 74AA8822; Tue, 9 Jun 2020 10:05:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 74AA8822 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1591689991; bh=tplNZVDA85EVnuaVCE5IBIOaeNy7f/ZFgs88QQg521U=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=K8+7Cr2Pmnt9DlVxOnyBMN6OlctXlSRbRXkLOCZKmnsziD9PGHTa92ti74D0IVeyr lAtFSt3m4+kJABG5GyxWav7NIJDvMhdY09SHoAkKuxD3nTywPQXdhr9NTeZiTK9Gg+ CaVf8fe0uDNJa9RkdDwZZp09FvnT5VHO9ueMyNkM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 07359F800F1; Tue, 9 Jun 2020 10:05:41 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1E49CF8028C; Tue, 9 Jun 2020 10:05:38 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 04D66F80124 for ; Tue, 9 Jun 2020 10:05:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 04D66F80124 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A007FAB76; Tue, 9 Jun 2020 08:05:32 +0000 (UTC) Date: Tue, 09 Jun 2020 10:05:26 +0200 Message-ID: From: Takashi Iwai To: Christoph Hellwig Subject: Re: next-0519 on thinkpad x60: sound related? window manager crash In-Reply-To: <20200609054306.GA9606@lst.de> References: <20200520111136.GA3802@amd> <1591545088.74ii116nf2.none@localhost> <20200608061950.GA17476@lst.de> <1591624340.z01ejtod28.none@localhost> <20200609054306.GA9606@lst.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, x86@kernel.org, David Rientjes , tiwai@suse.com, linux-kernel@vger.kernel.org, "Alex Xu \(Hello71\)" , hch@infradead.org, mingo@redhat.com, bp@alien8.de, Pavel Machek , hpa@zytor.com, tglx@linutronix.de X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 09 Jun 2020 07:43:06 +0200, Christoph Hellwig wrote: > > On Mon, Jun 08, 2020 at 07:31:47PM -0700, David Rientjes wrote: > > On Mon, 8 Jun 2020, Alex Xu (Hello71) wrote: > > > > > Excerpts from Christoph Hellwig's message of June 8, 2020 2:19 am: > > > > Can you do a listing using gdb where this happens? > > > > > > > > gdb vmlinux > > > > > > > > l *(snd_pcm_hw_params+0x3f3) > > > > > > > > ? > > > > > > > > > > (gdb) l *(snd_pcm_hw_params+0x3f3) > > > 0xffffffff817efc85 is in snd_pcm_hw_params (.../linux/sound/core/pcm_native.c:749). > > > 744 while (runtime->boundary * 2 <= LONG_MAX - runtime->buffer_size) > > > 745 runtime->boundary *= 2; > > > 746 > > > 747 /* clear the buffer for avoiding possible kernel info leaks */ > > > 748 if (runtime->dma_area && !substream->ops->copy_user) > > > 749 memset(runtime->dma_area, 0, runtime->dma_bytes); > > > 750 > > > 751 snd_pcm_timer_resolution_change(substream); > > > 752 snd_pcm_set_state(substream, SNDRV_PCM_STATE_SETUP); > > > 753 > > > > > > > Working theory is that CONFIG_DMA_NONCOHERENT_MMAP getting set is causing > > the error_code in the page fault path. Debugging with Alex off-thread we > > found that dma_{alloc,free}_from_pool() are not getting called from the > > new code in dma_direct_{alloc,free}_pages() and he has not enabled > > mem_encrypt. > > While DMA_COHERENT_POOL absolutely should not select DMA_NONCOHERENT_MMAP > (and you should send your patch either way), I don't think it is going > to make a difference here, as DMA_NONCOHERENT_MMAP just means we > allows mmaps even for non-coherent devices, and we do not support > non-coherent devices on x86. > > >From the disassembly it seems like a vmalloc allocation is NULL, which > seems really weird as this patch shouldn't make a difference for them, > and I also only see a single places that allocates the field, and that > checks for an allocation failure. But the sound code is a little > hard to unwind sometimes. It's not clear which sound device being affected, but if it's HD-audio on x86, runtime->dma_area points to a vmapped buffer from SG-pages allocated by dma_alloc_coherent(). OTOH, if it's a USB-audio, runtime->dma_area is a buffer by vmalloc(). Takashi