Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [GIT PULL] ASoC updates for v4.15
Date: Mon, 13 Nov 2017 17:36:08 +0100	[thread overview]
Message-ID: <s5hshdi9lvr.wl-tiwai@suse.de> (raw)
In-Reply-To: <20171113163014.qtdfgpqiign5xahk@sirena.co.uk>

On Mon, 13 Nov 2017 17:30:14 +0100,
Mark Brown wrote:
> 
> On Mon, Nov 13, 2017 at 04:54:13PM +0100, Takashi Iwai wrote:
> 
> > BTW, one thing Linus requested in the last KS is to avoid merging to a
> > stub branch when you're managing topic branches.  If any, just smash
> > the rest branches into one of your branches, instead of merging into
> > the upstream point.  Just a reminder for the next time.
> 
> I saw the LWN writeup after Vinod mentioned it but what he seemed to be
> talking about was the practice of doing incremental merges to master
> each time a topic branch is updated and instead requesting that
> everything just get merged down at the end which is what I do.  Unless
> he says something directly I'm going to assume my understanding is
> correct, it's how I send all the stuff I send directly to him so if it
> was bothering him I guess he'd have said something.  I can't see that
> picking a random topic branch is going to be especially helpful either,
> it'd end up being one of the fixes branches as they go first which'd
> quite likely already be in his tree anyway and end up looking like an
> empty branch based off a non-tag which'd probably upset him more.  It's
> also the mechanism I'm using to merge fixes from him so there is stuff
> on there relative to the other branches.
> 
> If it's an actual problem I'm sure he'll say something.

Yeah, that's why I also took your pull request as is at this time.
Let's see :)

My understanding is that it's git-request-pull containing the marginal
stuff that annoys him.  He usually compares the diffstat between the
pull-request and the actual merge result, and it doesn't work when the
pull-request already contains the old commits in itself.


Takashi

  reply	other threads:[~2017-11-13 16:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 11:52 [GIT PULL] ASoC updates for v4.15 Mark Brown
2017-11-13 15:54 ` Takashi Iwai
2017-11-13 16:30   ` Mark Brown
2017-11-13 16:36     ` Takashi Iwai [this message]
2017-11-13 17:20       ` Mark Brown
2017-11-15  4:33       ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hshdi9lvr.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox