From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH RESEND] pcm_rate: Do not discard slave reported delay in status result. Date: Tue, 13 Dec 2016 12:49:18 +0100 Message-ID: References: <52e39131-9141-b466-e92a-ff19ffab6d3a@IEE.org> <372cbe9d-2456-75e0-cdaf-056df21a4b31@IEE.org> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 1165B261A1A for ; Tue, 13 Dec 2016 12:49:19 +0100 (CET) In-Reply-To: <372cbe9d-2456-75e0-cdaf-056df21a4b31@IEE.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Alan Young Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, 13 Dec 2016 12:43:04 +0100, Alan Young wrote: > > Hi, > > Sorry for the delay. I too got sidetracked by other work. > > On 28/11/16 19:11, Takashi Iwai wrote: > >> >@@ -1083,15 +1115,17 @@ static int snd_pcm_rate_status(snd_pcm_t *pcm, snd_pcm_status_t * status) > >> > status->state = SND_PCM_STATE_RUNNING; > >> > status->trigger_tstamp = rate->trigger_tstamp; > >> > } > >> >- snd_pcm_rate_sync_hwptr(pcm); > >> >+ snd_pcm_rate_sync_hwptr0(rate, status->hw_ptr); > > This can't work. > > > > I can fix it in my side, but OTOH, this made me wonder how you tested > > the patch... > > Why do you think that cannot work? I am pretty sure it is working just > fine for us but I am sure that it is possible that I have missed > something. Compare the argument you passed there and the function definition, it's obvious :) Takashi