From: Takashi Iwai <tiwai@suse.de>
To: "Lin, Mengdong" <mengdong.lin@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"mengdong.lin@linux.intel.com" <mengdong.lin@linux.intel.com>,
"Koul, Vinod" <vinod.koul@intel.com>,
"Shah, Hardik T" <hardik.t.shah@intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"Ughreja, Rakesh A" <rakesh.a.ughreja@intel.com>,
"Girdwood, Liam R" <liam.r.girdwood@intel.com>,
"Prusty, Subhransu S" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH v3 0/7] topology: Add support for vendor tuples
Date: Thu, 07 Apr 2016 16:58:14 +0200 [thread overview]
Message-ID: <s5hshyx5uux.wl-tiwai@suse.de> (raw)
In-Reply-To: <F46914AEC2663F4A9BB62374E5EEF8F84B9B4A51@shsmsx102.ccr.corp.intel.com>
On Thu, 07 Apr 2016 16:33:13 +0200,
Lin, Mengdong wrote:
>
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai@suse.de]
> > Sent: Thursday, April 07, 2016 5:22 PM
> > To: mengdong.lin@linux.intel.com
> > Cc: alsa-devel@alsa-project.org; broonie@kernel.org; perex@perex.cz;
> > Girdwood, Liam R; Lin, Mengdong; Koul, Vinod; Prusty, Subhransu S; Ughreja,
> > Rakesh A; Shah, Hardik T
> > Subject: Re: [PATCH v3 0/7] topology: Add support for vendor tuples
> >
> > On Thu, 07 Apr 2016 09:27:20 +0200,
> > mengdong.lin@linux.intel.com wrote:
> > >
> > > From: Mengdong Lin <mengdong.lin@linux.intel.com>
> > >
> > > This series addes support for vendor tuples to topology, to avoid
> > > importing binary data blob from other files.
> > >
> > > Backward compatibility of ABI is not impacted. A kernel patch is also
> > > submitted "ASoC: topology: ABI - Define types for vendor tuples".
> > >
> > > The 1st patch is small code cleanup.
> > > The 2nd patch is a preparation, since tuples will need the
> > > type-specific free handler.
> > >
> > > History:
> > > v2: add check on string length, use strtol() to get hex value,
> > > and fix memory leak.
> > > v3: Fix overflow on uuid string copy. Use strtoul() to get unsigned
> > > vendor values and check range, tested on 32 & 64 bit systems.
> >
> > The patches look good to me. The prerequisite is the change in the kernel
> > side. Mark, how about that?
> >
>
> I saw the kernel patch "ASoC: topology: ABI - Define types for vendor tuples" has been merged to ASoC kernel.
>
> Here is the link:
> http://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/commit/?h=for-next&id=e42839b012eb8179ed2e3571bfcd133fba5df154
OK, assuming that the kernel-side change will be in 4.7, I applied
this patch series now. Thanks.
Takashi
prev parent reply other threads:[~2016-04-07 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 7:27 [PATCH v3 0/7] topology: Add support for vendor tuples mengdong.lin
2016-04-07 7:28 ` [PATCH v3 1/7] topology: Use the generic pointer to free an element's object mengdong.lin
2016-04-07 7:29 ` [PATCH v3 2/7] topology: Define a free handler for the element mengdong.lin
2016-04-07 7:29 ` [PATCH v3 3/7] topology: Add doc for vendor tuples mengdong.lin
2016-04-07 7:29 ` [PATCH v3 4/7] topology: ABI - Define types " mengdong.lin
2016-04-07 7:29 ` [PATCH v3 5/7] topology: Add support for vendor tokens mengdong.lin
2016-04-07 7:29 ` [PATCH v3 6/7] topology: Add support for parsing vendor tuples mengdong.lin
2016-04-07 7:29 ` [PATCH v3 7/7] topology: Build data objects with tuples mengdong.lin
2016-04-07 9:22 ` [PATCH v3 0/7] topology: Add support for vendor tuples Takashi Iwai
2016-04-07 14:33 ` Lin, Mengdong
2016-04-07 14:58 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hshyx5uux.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hardik.t.shah@intel.com \
--cc=liam.r.girdwood@intel.com \
--cc=mengdong.lin@intel.com \
--cc=mengdong.lin@linux.intel.com \
--cc=rakesh.a.ughreja@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).