From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 00/48] Rewrite kernel messages with standard printk helpers Date: Thu, 27 Feb 2014 08:40:28 +0100 Message-ID: References: <1393430030-26704-1-git-send-email-tiwai@suse.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 5BA3F261737 for ; Thu, 27 Feb 2014 08:40:28 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Raymond Yau Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Thu, 27 Feb 2014 15:32:53 +0800, Raymond Yau wrote: > > 2014-02-26 23:53 GMT+08:00 Takashi Iwai : > > > Hi, > > > > this is another long series of patches for trivial cleanups. > > This time, they replace the printk and snd_print*() calls in ALSA PCI > > and USB drivers with dev_err() and co. This will give nicer and more > > consistent outputs. > > > > The only drawback by these replacements is that alsa-info.sh won't be > > able to catch the dmesg lines because it doesn't contain any longer > > the word "ALSA", but only show the module name like "snd_intel8x0". > > > > I'm going to fix alsa-info.sh on git soon later, but if you guys think > > "oh no it's disaster!", let me know. We need to reconsider a better > > way to put the known markers (like explicitly putting "ALSA" at the > > beginning.) > > > > > seem missing au88x0 Yes, because some driver codes are horrible to work on. Patches are welcome. > can the driver build as modules in kernel 3.11 (ubuntu 13.10) ? The dev_err() and co exist since ages ago, so it shouldn't be a problem. These patches, however, need the previous change of snd_card_new() to make the device pointer available in time. No idea about Ubuntu. Takashi