From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] HDMI - fix ELD monitor name length Date: Wed, 29 Jun 2011 08:50:57 +0200 Message-ID: References: <20110629062607.GA17342@localhost> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 928BA10385C for ; Wed, 29 Jun 2011 08:50:58 +0200 (CEST) In-Reply-To: <20110629062607.GA17342@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Wu Fengguang Cc: alsa-devel@alsa-project.org, Stephen Warren List-Id: alsa-devel@alsa-project.org At Wed, 29 Jun 2011 14:26:07 +0800, Wu Fengguang wrote: > > I noticed that the last character of the ELD monitor name is lost, > this fixes the issue. > > Signed-off-by: Wu Fengguang Thanks, applied now (with more changelog comments from your follow-up mail). Takashi > --- > sound/pci/hda/hda_eld.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- sound-2.6.orig/sound/pci/hda/hda_eld.c 2011-06-29 13:08:23.000000000 +0800 > +++ sound-2.6/sound/pci/hda/hda_eld.c 2011-06-29 14:13:25.000000000 +0800 > @@ -294,7 +294,7 @@ static int hdmi_update_eld(struct hdmi_e > snd_printd(KERN_INFO "HDMI: out of range MNL %d\n", mnl); > goto out_fail; > } else > - strlcpy(e->monitor_name, buf + ELD_FIXED_BYTES, mnl); > + strlcpy(e->monitor_name, buf + ELD_FIXED_BYTES, mnl + 1); > > for (i = 0; i < e->sad_count; i++) { > if (ELD_FIXED_BYTES + mnl + 3 * (i + 1) > size) { >