From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: snd-atmel-abdac: test wrong variable Date: Mon, 22 Nov 2010 09:01:10 +0100 Message-ID: References: <1290361209-15121-1-git-send-email-segoon@openwall.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id CEC2F103882 for ; Mon, 22 Nov 2010 09:01:10 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Vasiliy Kulikov List-Id: alsa-devel@alsa-project.org At Mon, 22 Nov 2010 07:56:41 +0100, Takashi Iwai wrote: > > At Sun, 21 Nov 2010 20:40:07 +0300, > Vasiliy Kulikov wrote: > > > > After clk_get() pclk is checked second time instead of sample_clk check. > > > > Signed-off-by: Vasiliy Kulikov > > Applied now. Thanks. Ah, I found out that PTR_ERR() should be fixed as well. An additional patch applied as below. thanks, Takashi === >>From e61aabdb7608fd63d9705ab8bbf16f5145acead2 Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Mon, 22 Nov 2010 08:58:13 +0100 Subject: [PATCH] ALSA: atmel - Fix the return value in error path In the commit 5ad57d20c91bdaf743bd8e3015df5a388314df8d ALSA: snd-atmel-abdac: test wrong variable the return value via PTR_ERR() had to be fixed as well. Signed-off-by: Takashi Iwai --- sound/atmel/abdac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c index 4e47baad..6e24091 100644 --- a/sound/atmel/abdac.c +++ b/sound/atmel/abdac.c @@ -422,7 +422,7 @@ static int __devinit atmel_abdac_probe(struct platform_device *pdev) sample_clk = clk_get(&pdev->dev, "sample_clk"); if (IS_ERR(sample_clk)) { dev_dbg(&pdev->dev, "no sample clock\n"); - retval = PTR_ERR(pclk); + retval = PTR_ERR(sample_clk); goto out_put_pclk; } clk_enable(pclk); -- 1.7.3.1