Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Huang Weiyi <weiyi.huang@gmail.com>
Cc: liam.girdwood@wolfsonmicro.com, alsa-devel@alsa-project.org,
	broonie@opensource.wolfsonmicro.com
Subject: Re: ALSA: ASoC codec: remove unused #include <version.h>
Date: Mon, 13 Oct 2008 03:51:00 +0200	[thread overview]
Message-ID: <s5hskr1z2ij.wl%tiwai@suse.de> (raw)
In-Reply-To: <20081012231108.E7F2.WEIYI.HUANG@gmail.com>

At Sun, 12 Oct 2008 23:12:56 +0800,
Huang Weiyi wrote:
> 
> The files below do not use LINUX_VERSION_CODE nor KERNEL_VERSION.
>  sound/soc/codecs/ad1980.c
>  sound/soc/codecs/wm8580.c
>  sound/soc/codecs/wm8900.c
> 
> This patch removes the said #include <version.h>.
> 
> Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>

Thanks, applied now.


Takashi

> diff --git a/sound/soc/codecs/ad1980.c b/sound/soc/codecs/ad1980.c
> index 4e09c1f..1397b8e 100644
> --- a/sound/soc/codecs/ad1980.c
> +++ b/sound/soc/codecs/ad1980.c
> @@ -13,7 +13,6 @@
> 
>  #include <linux/init.h>
>  #include <linux/module.h>
> -#include <linux/version.h>
>  #include <linux/kernel.h>
>  #include <linux/device.h>
>  #include <sound/core.h>
> diff --git a/sound/soc/codecs/wm8580.c b/sound/soc/codecs/wm8580.c
> index df1ffbe..a10edda 100644
> --- a/sound/soc/codecs/wm8580.c
> +++ b/sound/soc/codecs/wm8580.c
> @@ -18,7 +18,6 @@
> 
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
> -#include <linux/version.h>
>  #include <linux/kernel.h>
>  #include <linux/init.h>
>  #include <linux/delay.h>
> diff --git a/sound/soc/codecs/wm8900.c b/sound/soc/codecs/wm8900.c
> index 0b8c6d3..3b326c9 100644
> --- a/sound/soc/codecs/wm8900.c
> +++ b/sound/soc/codecs/wm8900.c
> @@ -18,7 +18,6 @@
> 
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
> -#include <linux/version.h>
>  #include <linux/kernel.h>
>  #include <linux/init.h>
>  #include <linux/delay.h>
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

  reply	other threads:[~2008-10-13  1:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-12 15:12 ALSA: ASoC codec: remove unused #include <version.h> Huang Weiyi
2008-10-13  1:51 ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-10-31 14:50 Huang Weiyi
2008-10-31 14:51 ` Mark Brown
2008-11-04 17:08 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hskr1z2ij.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=liam.girdwood@wolfsonmicro.com \
    --cc=weiyi.huang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox