Re: [RFC] [Patch 1/2] Add virtual master control

[Takashi Iwai <tiwai@suse.de>]

At Fri, 2 May 2008 14:01:54 -0400,
Daniel Jacobowitz wrote:
> 
> On Sat, Mar 22, 2008 at 03:15:51PM -0400, Daniel Jacobowitz wrote:
> > On Sat, Mar 22, 2008 at 05:31:21PM +0100, Takashi Iwai wrote:
> > > Thanks.  This kind of change is basically good to apply, I think, but
> > > a couple of things related are in my mind:
> > > 
> > > - other AC97 codecs need similar hacks, so it could be done
> > >   cleaner (in a more generic way) than in each patch_*()?
> > > - headphone and line-out have the similar issue - it's handled as a
> > >   bind-control right now, though
> > > - what about if the device actually uses only two channels although
> > >   codec supports more than two?  Then the additional master control
> > >   makes little sense.  But, we have no way to know it from the codec
> > >   itself.  Another quirk table?  That's to be avoided...
> > > 
> > > Since this is a non-urgent fix and I'll be on vacation for three weeks
> > > from tomorrow, I'd like to keep this pending unless other developers
> > > want to put this in.  Is it OK?
> > 
> > Fine with me.  I don't think I can make broader changes than this
> > kind, because I don't know much about AC97; maybe there can be a flag
> > on recognized codecs saying which channels the front volume really
> > controls?
> > 
> > I noticed that the PCM mixer also only affected my front speakers.
> 
> Hi Takashi,
> 
> Have you had another chance to look at this?

Not quite, unfortunately.  But, in the end, I think it's relatively
harmless to take your patch as is, since it's pretty local to VT161x
codecs.

I'll put it on my local tree and make testing, then merge to the
public tree soon later.


thanks,

Takashi