From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] [ML403-AC97CR] Remove duplicate
	snd_card_set_dev().
Date: Mon, 17 Mar 2008 08:42:28 +0100
Message-ID: <s5hskypu78b.wl%tiwai@suse.de>
References: <1205574189.14214.10.camel@md40100b.ft>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (ns.suse.de [195.135.220.2])
	by alsa0.perex.cz (Postfix) with ESMTP id 90085243AC
	for <alsa-devel@alsa-project.org>; Mon, 17 Mar 2008 08:42:28 +0100 (CET)
In-Reply-To: <1205574189.14214.10.camel@md40100b.ft>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Joachim Foerster <mls.JOFT@gmx.de>
Cc: alsa-devel <alsa-devel@alsa-project.org>
List-Id: alsa-devel@alsa-project.org

At Sat, 15 Mar 2008 10:43:09 +0100,
Joachim Foerster wrote:
> 
> Hi Takashi,
> 
> I noticed, that there was a change in ml403-ac97cr.c, which introduces a
> second call of snd_card_set_dev() in the _probe()-function. The
> "original" one is in the snd_ml403_ac97cr_create()-function.
> 
> According the other changes, I guess, we want to have it in the
> _probe()-function, now (=> following patch)?

It's no big matter whether it's set.  The only requirement is that
it must be called before registering the device, typically via
snd_card_register().


> From: Joachim Foerster <JOFT@gmx.de>
> 
> We want to have snd_card_set_dev() in _probe(), but not a second one in
> snd_ml403_ac97cr_create().
> 
> Signed-off-by: Joachim Foerster <JOFT@gmx.de>

Applied to ALSA tree.  Thanks.


Takashi