From: Takashi Iwai <tiwai@suse.de>
To: Jiang zhe <zhe.jiang@intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: Same pci id for different ASUS machine
Date: Thu, 13 Mar 2008 08:37:37 +0100 [thread overview]
Message-ID: <s5hskyvdqgu.wl%tiwai@suse.de> (raw)
In-Reply-To: <1205376529.15217.8.camel@localhost.localdomain>
At Thu, 13 Mar 2008 10:48:49 +0800,
Jiang zhe wrote:
>
> Hi,
>
> According to the [0003839]
> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3839
>
> The PCI ID of ASUS F9S is 1043:1339 and "model=lenovo" works for it.
> But I found that ASUS G1 have the same id and model is 3stack in the
> alsa driver.
>
> Which one is true?
The question is rather which one is "better". At the time ASUS G1
quirk was added, there was no lenovo model preset. If lenovo preset
works better, we should take it, as the devices with the same PCI SSID
are supposed to be compatible.
Takashi
> --- alsa-driver-hg20080313/alsa-kernel/pci/hda/patch_realtek.c
> 2008-03-13 09:00:08.000000000 +0800
> +++ b/alsa-kernel/pci/hda/patch_realtek.c 2008-03-13 10:38:57.000000000
> +0800
> @@ -12591,7 +12591,7 @@ static struct snd_pci_quirk alc861vd_cfg
> SND_PCI_QUIRK(0x1019, 0xa88d, "Realtek ALC660 demo", ALC660VD_3ST),
> SND_PCI_QUIRK(0x103c, 0x30bf, "HP TX1000", ALC861VD_HP),
> SND_PCI_QUIRK(0x1043, 0x12e2, "Asus z35m", ALC660VD_3ST),
> - SND_PCI_QUIRK(0x1043, 0x1339, "Asus G1", ALC660VD_3ST),
> + SND_PCI_QUIRK(0x1043, 0x1339, "Asus F9S", ALC861VD_LENOVO),
> SND_PCI_QUIRK(0x1043, 0x81e7, "ASUS", ALC660VD_3ST_DIG),
> SND_PCI_QUIRK(0x10de, 0x03f0, "Realtek ALC660 demo", ALC660VD_3ST),
> SND_PCI_QUIRK(0x1179, 0xff00, "Toshiba A135", ALC861VD_LENOVO),
>
> [2 asus_F9s_alc861vd.patch <text/x-patch; UTF-8 (7bit)>]
> --- alsa-driver-hg20080313/alsa-kernel/pci/hda/patch_realtek.c 2008-03-13 09:00:08.000000000 +0800
> +++ b/alsa-kernel/pci/hda/patch_realtek.c 2008-03-13 10:38:57.000000000 +0800
> @@ -12591,7 +12591,7 @@ static struct snd_pci_quirk alc861vd_cfg
> SND_PCI_QUIRK(0x1019, 0xa88d, "Realtek ALC660 demo", ALC660VD_3ST),
> SND_PCI_QUIRK(0x103c, 0x30bf, "HP TX1000", ALC861VD_HP),
> SND_PCI_QUIRK(0x1043, 0x12e2, "Asus z35m", ALC660VD_3ST),
> - SND_PCI_QUIRK(0x1043, 0x1339, "Asus G1", ALC660VD_3ST),
> + SND_PCI_QUIRK(0x1043, 0x1339, "Asus F9S", ALC861VD_LENOVO),
> SND_PCI_QUIRK(0x1043, 0x81e7, "ASUS", ALC660VD_3ST_DIG),
> SND_PCI_QUIRK(0x10de, 0x03f0, "Realtek ALC660 demo", ALC660VD_3ST),
> SND_PCI_QUIRK(0x1179, 0xff00, "Toshiba A135", ALC861VD_LENOVO),
next prev parent reply other threads:[~2008-03-13 11:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 2:48 Same pci id for different ASUS machine Jiang zhe
2008-03-13 7:37 ` Takashi Iwai [this message]
2008-03-17 20:19 ` Andy Shevchenko
2008-03-18 17:12 ` Takashi Iwai
2008-03-18 18:57 ` Mark Brown
2008-03-19 14:45 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hskyvdqgu.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=zhe.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox