From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] Fix ALSA resume Date: Mon, 06 Dec 2004 15:22:03 +0100 Message-ID: References: <1102195391.1560.65.camel@tux.rsn.bth.se> <20041204172855.350100d0.akpm@osdl.org> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20041204172855.350100d0.akpm@osdl.org> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Andrew Morton Cc: Martin Josefsson , torvalds@osdl.org, linux-kernel@vger.kernel.org, Joshua Kwan , alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Sat, 4 Dec 2004 17:28:55 -0800, Andrew Morton wrote: > > But Joshua crosses his heart and swears that the pci_disable_device() is > also needed for a successful swsusp resume. Yes. This would make suspend safer. The linux-sound bk tree already includes the fix above and the patches to add pci_disable_device() in appropriate places. Andrew, could you update bk-alsa patch set? > Should snd_card_pci_suspend() be doing the pci_disable_device() as well, or > it that a responsibility of the driver which called snd_card_pci_suspend()? So far, we suppose that the lowlevel suspend() callback should call pci_disable_device() although we can move it to the common place, snd_card_pci_suspend(). Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/