From: Takashi Iwai <tiwai@suse.de>
To: Benny Sjostrand <gorm@cucumelo.org>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: [PATCH] cs46xx, rear and IEC958 PCM channels, moved SCB initialization from from _prepare() -> _hw_params(), etc.
Date: Thu, 31 Oct 2002 11:40:42 +0100 [thread overview]
Message-ID: <s5hsmymsxg5.wl@alsa2.suse.de> (raw)
In-Reply-To: <3DC072E0.7060608@cucumelo.org>
At Thu, 31 Oct 2002 01:01:36 +0100,
Benny Sjostrand wrote:
>
> Hi!
>
> Once again, updated cs46xx patch.
> So, here's a attempt to move stuff from snd_cs46xx_playback_prepare(...),
> to snd_cs46xx_hw_params(...), thing works, but I dont like the aproach,
> the main reason is that snd_cs46xx_hw_params(...) is not a good place
> for adjusting the sample rate. I've noticed that some OSS applications
> the hw_params is called upto 3 times, and I've found a way to find
> out when actually the sample rate is set to the value the application
> is going to proceed with.
thanks, applied to cvs now.
basically, prepare may be called also mutliple times by OSS emulation,
so the situation is identical.
on OSS, you _have to_ change the rate many times.
Takashi
-------------------------------------------------------
This sf.net email is sponsored by: Influence the future
of Java(TM) technology. Join the Java Community
Process(SM) (JCP(SM)) program now.
http://ads.sourceforge.net/cgi-bin/redirect.pl?sunm0004en
next prev parent reply other threads:[~2002-10-31 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-31 0:01 [PATCH] cs46xx, rear and IEC958 PCM channels, moved SCB initialization from from _prepare() -> _hw_params(), etc Benny Sjostrand
2002-10-31 8:35 ` patch download (was: [PATCH] cs46xx, rear and IEC958 PCM channels, moved SCB initialization from from _prepare() -> _hw_params(), etc.) Benny Sjostrand
2002-10-31 10:40 ` Takashi Iwai [this message]
2002-10-31 15:12 ` [PATCH] cs46xx, rear and IEC958 PCM channels, moved SCB initialization from from _prepare() -> _hw_params(), etc Benny Sjostrand
2002-10-31 15:13 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsmymsxg5.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@lists.sourceforge.net \
--cc=gorm@cucumelo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox