From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10E6EC433F5 for ; Fri, 4 Mar 2022 17:06:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3FF551B5F; Fri, 4 Mar 2022 18:05:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3FF551B5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646413586; bh=N4TX+sSfmu0tOn0WgZ6ov1c2S4BWnMECdRpMEtawBO0=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=T7NmDIp1F7gVoe5mbpTN2SN5ShzHUwvFB//zxhqasYcfykch9nAS9rRg9dQEHPEWE p91TlxRLKQ1V8D46ekyxtWOKOlyoKw8e43e7Ub8xu1/s7SpNw0/HAbnl62d047a3C6 Jh52hxQ2vtlYAIUa9Sg1l1jKX/B/zbgj8OEiF5mo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D35F0F800FA; Fri, 4 Mar 2022 18:05:35 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5EAB3F800F2; Fri, 4 Mar 2022 18:05:34 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 68044F800F2 for ; Fri, 4 Mar 2022 18:05:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 68044F800F2 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="nptw50rM"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="wJxIZo8w" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 032901F38A; Fri, 4 Mar 2022 17:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646413526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RJJQkXEtIZssPACfh5YufyI5icApc9EN826U5KQ4k8I=; b=nptw50rM0VdvC9u79m/n4x6+NNExCelgY72Il6bnoAyPzJ9JytdRX3jDexAeYzvQWJSBEr 6UvOeWXWeCCK92sKZNUdK49zzK5e5PGpCQk8hDbUXgVvW8cYB2NBGNIDS3GRVs+z48xg/e XhF/VHO3wBLnWSAZIruvaxtYIXVDCHE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646413526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RJJQkXEtIZssPACfh5YufyI5icApc9EN826U5KQ4k8I=; b=wJxIZo8wxjPX5NVD/TrbS09rZdD/C7Qq2ck3W9lpbIsm3rNWSGJciMzss6th6E/tFgVuB6 AGVpZVGzwWkXBvAQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id E5437A3B8A; Fri, 4 Mar 2022 17:05:25 +0000 (UTC) Date: Fri, 04 Mar 2022 18:05:25 +0100 Message-ID: From: Takashi Iwai To: Lucas Tanure Subject: Re: [PATCH v2 00/20] Support external boost at CS35l41 ASoC driver In-Reply-To: <20220304150721.3802-1-tanureal@opensource.cirrus.com> References: <20220304150721.3802-1-tanureal@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Takashi Iwai , Rob Herring , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 04 Mar 2022 16:07:01 +0100, Lucas Tanure wrote: > > Move the support for CS35L41 external boost to its shared library > for ASoC use. > This move resulted in cs35l41_hda_reg_sequence being removed, > and its steps were broken down into regmap writes or functions > from the library. And hardware configuration struct was unified > for its use in the shared lib. > While at it, some minor bugs were found and fixed it. > > v2 changelog: > - Instead of removing the log, playback actions will log the last regmap access. > - Documentation patch with the correct subject line and fixed bug reported by Rob Herring on the > provided example. > > Previous versions: > v1: https://lkml.org/lkml/2022/3/3/759 > > David Rhodes (2): > ASoC: cs35l41: Fix GPIO2 configuration > ASoC: cs35l41: Document CS35l41 External Boost > > Lucas Tanure (18): > ASoC: cs35l41: Fix max number of TX channels > ASoC: cs35l41: Fix DSP mbox start command and global enable order > ASoC: cs35l41: Remove unnecessary param > sound: cs35l41: Unify hardware configuration > sound: cs35l41: Check hw_config before using it > sound: cs35l41: Move cs35l41_gpio_config to shared lib > hda: cs35l41: Fix I2S params comments > hda: cs35l41: Always configure the DAI > hda: cs35l41: Add Boost type flag > hda: cs35l41: Put the device into safe mode for external boost > hda: cs35l41: Mute the device before shutdown > sound: cs35l41: Enable Internal Boost in shared lib > hda: cs35l41: Move boost config to initialization code > hda: cs35l41: Remove cs35l41_hda_reg_sequence struct > hda: cs35l41: Reorganize log for playback actions > hda: cs35l41: Handle all external boost setups the same way > hda: cs35l41: Move external boost handling to lib for ASoC use > ASoC: cs35l41: Support external boost Through a quick glance, the code changes look OK in general. But please correct the subject prefix. For non-ASoC patches (that begin with either "hda" or "sound" in this patch set) should be with "ALSA: hda: xxx" or such. Also, although I respect the spirit of Haiku, the patch logs could be a bit more verbose and descriptive, and the texts can be folded at the right column. Some patch descriptions are too short, e.g. patch 15 doesn't mention about the new usleep_range() addition in the code. thanks, Takashi