From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF86C4338F for ; Mon, 23 Aug 2021 15:13:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E71FE61361 for ; Mon, 23 Aug 2021 15:13:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E71FE61361 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5AFAE74C; Mon, 23 Aug 2021 17:12:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5AFAE74C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1629731607; bh=OEqHqilFKmP1WfKp4oVJiZRSB2Ln5go87Ttzlxi6DzU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=C+LMaUds7nEvvkK5WR4qxqifHIVqFUUBMQHSS7Rsc9n78cDQDTNobdl0gGD7lckP1 OpAVZVY4k7/QOrIHH2dmBva4kR0RehKjmjPQ6BiPAISIWuetH9hnVuLpM2wbm28L3s wcfMxhQ5PMmS7+NA37chXnyD9B0148hXXoHiiJOM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F095FF8020C; Mon, 23 Aug 2021 17:12:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 57C2FF80217; Mon, 23 Aug 2021 17:12:35 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2B140F800B6 for ; Mon, 23 Aug 2021 17:12:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2B140F800B6 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="JOtE7jUJ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="FZOk4f1A" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id EB75621FED; Mon, 23 Aug 2021 15:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1629731552; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cQyJYIHM+6xNxqcdWrdNvPV7A52Gvpi9djJtBrli4c4=; b=JOtE7jUJEaWPdqS3bB1VCCgGOxZ8jeFIoxHHQNcxj3Jsmu1i+jvlpuZign6mhf+snYUDQP A22VbZUcugEaEBev6qoguJfGbnHZ4aIjIqqtwYIxWihxB48QeWbIZu+MmAr/8KorGGO/Zf mCvtl9ngljp2i/UyMSgshXq3uKUaW7M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1629731552; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cQyJYIHM+6xNxqcdWrdNvPV7A52Gvpi9djJtBrli4c4=; b=FZOk4f1AqRuYbtPrKDUZXw54JPpsyGgJS6crRHwfgSkKZe/s3RxKDrR84nMJvJT+OloOms 1SmxRD/sXo21pOAg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id E6C70A3BC4; Mon, 23 Aug 2021 15:12:32 +0000 (UTC) Date: Mon, 23 Aug 2021 17:12:32 +0200 Message-ID: From: Takashi Iwai To: Arkadiusz Bokowy Subject: Re: [PATCH 2/2] plugio: Check for pointer callback error codes In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 23 Aug 2021 13:48:38 +0200, Arkadiusz Bokowy wrote: > > By checking error code returned by the pointer callback, we can > determine more precisely PCM state. Previous implementation assumed, > that a software PCM can only produce overrun or underrun. It was > impossible to mark software PCM as disconnected. > > Signed-off-by: Arkadiusz Bokowy Please fix MUA setup. Also... > --- > src/pcm/pcm_ioplug.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/src/pcm/pcm_ioplug.c b/src/pcm/pcm_ioplug.c > index c96104e9..0e27e121 100644 > --- a/src/pcm/pcm_ioplug.c > +++ b/src/pcm/pcm_ioplug.c > @@ -81,11 +81,21 @@ static int snd_pcm_ioplug_hw_ptr_update(snd_pcm_t *pcm) > } > io->last_hw = (snd_pcm_uframes_t)hw; > } else { > + switch (hw) { > + case -ESTRPIPE: > + io->data->state = SND_PCM_STATE_SUSPENDED; > + break; > + case -ENODEV: > + io->data->state = SND_PCM_STATE_DISCONNECTED; > + break; > + default: > + io->data->state = SND_PCM_STATE_XRUN; > + } > if (io->data->state == SND_PCM_STATE_DRAINING) > snd_pcm_ioplug_drop(pcm); > else > io->data->state = SNDRV_PCM_STATE_XRUN; > - return -EPIPE; > + return hw; Be careful about the handling of the draining case. thanks, Takashi