From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B137CC433E0 for ; Fri, 5 Mar 2021 14:20:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02D516509E for ; Fri, 5 Mar 2021 14:20:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02D516509E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B39631799; Fri, 5 Mar 2021 15:19:30 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B39631799 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614954020; bh=aEm+5hiKEX233thaxjLimqWEnYaowH05HEy6CEy1cjg=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=APAq7wLPQGDbTYQ/Ax/6MXn5LYkEmjJUaRJVFKvYNxu8miKH6m4RyzgDNEWwNX7Rk shVOnfFjKFZuv2wCzL6+WuWu/Nr40WIJhPW9iH1mufvaXDyuvp1UC6JIz+7NeMp5br +BpgNhI5OqvCIWBOqQdurtan3VyjhRBP8+LzENVw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EA499F80257; Fri, 5 Mar 2021 15:19:29 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1B9CDF80257; Fri, 5 Mar 2021 15:19:26 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B865DF800F3 for ; Fri, 5 Mar 2021 15:19:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B865DF800F3 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BCB6AACCF; Fri, 5 Mar 2021 14:19:21 +0000 (UTC) Date: Fri, 05 Mar 2021 15:19:21 +0100 Message-ID: From: Takashi Iwai To: Hui Wang Subject: Re: [PATCH v2] ALSA: hda - bind headset buttons to the headphone jack In-Reply-To: <20210305092608.109599-1-hui.wang@canonical.com> References: <20210305092608.109599-1-hui.wang@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 05 Mar 2021 10:26:08 +0100, Hui Wang wrote: > > With the HDA driver, if the headset buttons are supported, an audio > Jack will be created for them. This audio Jack is a bit confusing to > users since it can't report headphone/mic insertion events but it > claims to support these events. > > And in addition, the driver already builds a headphone Jack and a mic > Jack, and most of those buttons are used for headphone playback, so > do some change to bind those buttons to the headphone Jack. After this > change, the key events are generated from NID 0x55, and are reported > to the input layer via headphone jack (NID 0x21). > > If there is no headphone Jack, then build an audio jack to support > those buttons same as previously. > > Signed-off-by: Hui Wang > --- > In the v2, add a function snd_hda_jack_set_button_state(), > the codec driver calls it to report the button state. Thanks, applied now to for-next branch. Takashi