From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE57C433DF for ; Tue, 16 Jun 2020 13:25:05 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4A9320B1F for ; Tue, 16 Jun 2020 13:25:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="En2vtuKg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4A9320B1F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 346AC1671; Tue, 16 Jun 2020 15:24:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 346AC1671 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1592313903; bh=wMns8UOB6hPUY4faelVHLTE50UjQ6oRnVfxAbSP8X84=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=En2vtuKgIwZ55d6GDiAF4G1uLxTI/t6Bqu6jvyNsjfRDKmIiFtyfhtQV6kyFMyiAl 5AJgLWv9fSX1CI2QhW435bd5uXrfbYnvglFGjXePOYVpgVr7IJH1U6OHrgrJEwpptE mkBpcOG+l2WlUaLIqHOKR8AKAX0bR+QNXmC4GNGE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B6787F80217; Tue, 16 Jun 2020 15:24:12 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3CC5DF8022B; Tue, 16 Jun 2020 15:24:11 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A9F1EF800EF for ; Tue, 16 Jun 2020 15:24:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A9F1EF800EF X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 547EFAD39; Tue, 16 Jun 2020 13:24:08 +0000 (UTC) Date: Tue, 16 Jun 2020 15:24:03 +0200 Message-ID: From: Takashi Iwai To: Mark Hills Subject: Re: [PATCH 2/3] echoaudio: Prevent races in calls to set_audio_format() In-Reply-To: <20200616131743.4793-2-mark@xwax.org> References: <2006161409060.30751@stax.localdomain> <20200616131743.4793-2-mark@xwax.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 16 Jun 2020 15:17:42 +0200, Mark Hills wrote: > > The function uses chip->comm_page which needs locking against > other use at the same time. > > Signed-off-by: Mark Hills > --- > sound/pci/echoaudio/echoaudio.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c > index 82a49dfd2384..8cf08988959f 100644 > --- a/sound/pci/echoaudio/echoaudio.c > +++ b/sound/pci/echoaudio/echoaudio.c > @@ -711,9 +711,22 @@ static int pcm_prepare(struct snd_pcm_substream *substream) > > if (snd_BUG_ON(pipe_index >= px_num(chip))) > return -EINVAL; > - if (snd_BUG_ON(!is_pipe_allocated(chip, pipe_index))) > + > + /* > + * We passed checks we can do independently; now take > + * exclusive control > + */ > + > + spin_lock(&chip->lock); You need spin_lock_irq() and spin_unlock_irq(), as the prepare callback in in sleepable context. thanks, Takashi