From: Takashi Iwai <tiwai@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "ALSA Development Mailing List" <alsa-devel@alsa-project.org>,
"Ayman Bagabas" <ayman.bagabas@gmail.com>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
"Hui Wang" <hui.wang@canonical.com>,
ibm-acpi-devel@lists.sourceforge.net,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Linux LED Subsystem" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH 1/6] leds: trigger: Introduce audio mute LED trigger
Date: Tue, 27 Nov 2018 12:04:37 +0100 [thread overview]
Message-ID: <s5htvk2ye62.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAHp75VcLuxBP2SrvN-B698BJ8=SGqPat-s=2k9cV+ObcoE8kww@mail.gmail.com>
On Mon, 26 Nov 2018 23:58:36 +0100,
Andy Shevchenko wrote:
>
> On Mon, Nov 26, 2018 at 7:14 PM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > This patch adds a new LED trigger for coupling the audio mixer change
> > with the LED on laptops or other devices. Currently there are two
> > trigger types, "audio-mute" and "audio-micmute".
> >
> > The audio driver triggers the LED brightness change via
> > ledtrig_audio_set() call with the proper type (either mute or
> > mic-mute). OTOH, the consumers may call ledtrig_audio_get() for the
> > initial brightness value that may have been set by the audio driver
> > beforehand.
> >
> > This new stuff will be used by HD-audio codec driver and some platform
> > drivers (thinkpad_acpi and dell-laptop, also upcoming huawei-wmi).
>
> > +#include <linux/module.h>
>
> > +#include <linux/init.h>
>
> Only on of above is needed, I think you meant module.h.
Right, dropped init.h inclusion. Also sorted now.
thanks,
Takashi
next prev parent reply other threads:[~2018-11-27 11:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 17:11 [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it) Takashi Iwai
2018-11-26 17:11 ` [PATCH 2/6] platform/x86: dell-laptop: Add micmute LED trigger support Takashi Iwai
2018-11-26 17:11 ` [PATCH 3/6] platform/x86: thinkpad_acpi: Add audio mute LED classdev support Takashi Iwai
2018-11-26 23:04 ` Andy Shevchenko
2018-11-27 11:04 ` Takashi Iwai
[not found] ` <20181126171126.20280-1-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-11-26 17:11 ` [PATCH 1/6] leds: trigger: Introduce audio mute LED trigger Takashi Iwai
[not found] ` <20181126171126.20280-2-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-11-26 20:59 ` Jacek Anaszewski
2018-11-27 11:04 ` Takashi Iwai
2018-11-26 22:58 ` Andy Shevchenko
2018-11-27 11:04 ` Takashi Iwai [this message]
2018-11-26 17:11 ` [PATCH 4/6] ALSA: hda - Support led audio trigger Takashi Iwai
2018-11-26 17:11 ` [PATCH 6/6] platform/x86: thinkpad_acpi: Drop superfluous exported function Takashi Iwai
2018-11-26 17:11 ` [PATCH 5/6] platform/x86: dell-laptop: " Takashi Iwai
2018-11-26 23:09 ` [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it) Andy Shevchenko
2018-11-27 11:05 ` Takashi Iwai
2018-11-27 8:44 ` Pavel Machek
2018-11-27 11:06 ` Takashi Iwai
2018-11-28 11:18 ` Pali Rohár
2018-11-28 11:38 ` Takashi Iwai
2018-11-28 12:25 ` Pavel Machek
2018-11-28 12:58 ` Takashi Iwai
2018-11-28 13:40 ` Andy Shevchenko
2018-11-28 19:58 ` Jacek Anaszewski
2018-11-28 20:34 ` Pavel Machek
2018-11-28 20:46 ` Pali Rohár
2018-11-28 21:00 ` Jacek Anaszewski
2018-11-28 21:22 ` Pavel Machek
2018-11-29 21:23 ` Jacek Anaszewski
2018-11-29 21:56 ` Takashi Iwai
2018-11-30 10:42 ` Andy Shevchenko
2018-12-01 14:41 ` Well-known LED names was " Pavel Machek
2018-12-08 21:59 ` Jacek Anaszewski
2018-11-28 21:01 ` Pavel Machek
2018-11-27 10:26 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2018-11-27 11:11 ` Takashi Iwai
2018-11-28 11:14 ` Pali Rohár
2018-11-28 11:30 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htvk2ye62.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=ayman.bagabas@gmail.com \
--cc=hui.wang@canonical.com \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox