From: Takashi Iwai <tiwai@suse.de>
To: "Jörg Krause" <joerg.krause@embedded.rocks>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: pcm5102a: Provide a menu selection text
Date: Thu, 05 Jan 2017 21:29:42 +0100 [thread overview]
Message-ID: <s5htw9dntc9.wl-tiwai@suse.de> (raw)
In-Reply-To: <1483647439.27207.3.camel@embedded.rocks>
On Thu, 05 Jan 2017 21:17:19 +0100,
Jörg Krause wrote:
>
> On Thu, 2016-12-29 at 20:04 +0100, Takashi Iwai wrote:
> > On Thu, 29 Dec 2016 16:59:43 +0100,
> > Jörg Krause wrote:
> > >
> > > On Wed, 2016-12-28 at 16:09 +0100, Takashi Iwai wrote:
> > > > On Tue, 20 Dec 2016 17:26:59 +0100,
> > > > Jörg Krause wrote:
> > > > >
> > > > > Provide a menu selection text so that users can enable, disable
> > > > > or
> > > > > mark it as module in menuconfig.
> > > >
> > > > What's the reason to enable it at all? The codec entries are
> > > > usually
> > > > not user-selectable but enabled by the machine driver.
> > >
> > > To allow using it with the simple-card driver.
> >
> > See, now you know what's missing in your patch :)
>
> Unforunately not. I adopted commit 465011fc5671 which does not has any
> dependency. Please enlighten me :)
The missing piece is one of the most important things in writing a
patch -- the proper information explaining "why" this change is
needed, preferably in a form of changelog text. Instead, you wrote
merely what you changed, which is pretty obvious and doesn't help
understanding.
The commit you referred to is no good example in this manner at all,
unfortunately.
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-01-05 20:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 16:26 [PATCH] ASoC: pcm5102a: Provide a menu selection text Jörg Krause
2016-12-28 15:09 ` Takashi Iwai
2016-12-29 15:59 ` Jörg Krause
2016-12-29 19:04 ` Takashi Iwai
2017-01-05 20:17 ` Jörg Krause
2017-01-05 20:29 ` Takashi Iwai [this message]
2017-01-06 7:33 ` Jörg Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htw9dntc9.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=joerg.krause@embedded.rocks \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox