alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Anssi Hannula <anssi.hannula@iki.fi>
Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Extend DragonFly dB scale quirk to cover other variants
Date: Fri, 23 Sep 2016 08:34:15 +0200	[thread overview]
Message-ID: <s5htwd7f7ko.wl-tiwai@suse.de> (raw)
In-Reply-To: <1474602227-7122-1-git-send-email-anssi.hannula@iki.fi>

On Fri, 23 Sep 2016 05:43:47 +0200,
Anssi Hannula wrote:
> 
> The DragonFly quirk added in 42e3121d90f4 ("ALSA: usb-audio: Add a more
> accurate volume quirk for AudioQuest DragonFly") applies a custom dB map
> on the volume control when its range is reported as 0..50 (0 .. 0.2dB).
> 
> However, there exists at least one other variant (hw v1.0c, as opposed
> to the tested v1.2) which reports a different non-sensical volume range
> (0..53) and the custom map is therefore not applied for that device.
> 
> This results in all of the volume change appearing close to 100% on
> mixer UIs that utilize the dB TLV information.
> 
> Add a fallback case where no dB TLV is reported at all if the control
> range is not 0..50 but still 0..N where N <= 1000 (3.9 dB). Also
> restrict the quirk to only apply to the volume control as there is also
> a mute control which would match the check otherwise.
> 
> Signed-off-by: Anssi Hannula <anssi.hannula@iki.fi>
> Reported-by: David W <regulars@d-dub.org.uk>
> Tested-by: David W <regulars@d-dub.org.uk>
> Cc: <stable@vger.kernel.org>

Thanks, I applied with Fixes tag.


Takashi

      reply	other threads:[~2016-09-23  6:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-23  3:43 [PATCH] ALSA: usb-audio: Extend DragonFly dB scale quirk to cover other variants Anssi Hannula
2016-09-23  6:34 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5htwd7f7ko.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=anssi.hannula@iki.fi \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).