alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
	patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com,
	broonie@kernel.org
Subject: Re: [PATCH v5 0/4] Propagate errors out from compressed streams
Date: Wed, 20 Apr 2016 15:09:30 +0200	[thread overview]
Message-ID: <s5htwiw1l6d.wl-tiwai@suse.de> (raw)
In-Reply-To: <1461156003-24422-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>

On Wed, 20 Apr 2016 14:39:59 +0200,
Charles Keepax wrote:
> 
> If the DSP suffers an unrecoverable error, the driver likely
> knows about this, however the framework may not get informed
> because errors returned from pointer requests are ignored within
> the framework.
> 
> Things work out fine if user-space is doing a read as reads
> return error status back to user-space so the user can find out
> that things have gone bad. However, if user-space is doing an
> avail request there is no path for the error to come back up to
> user-space. The pointer request returns zero available data, so a
> read never happens and we basically just end up sitting waiting
> for data on a stream that we know full well has died.
> 
> This patch set attempts to address this and ensure that errors
> are fully propagated to user-space and we don't ever end up wait
> for data that will never come.
> 
> Changes since v4:
>  - Fix issue noticed by Vinod whereby the error state was being
>    overwritten when snd_compr_stop was called
> 
> It might be easiest to put the ASoC changes through Mark's tree
> as there are some merge conflicts otherwise, as such I have based
> this series on Mark's tree.

If it goes through Mark's tree, feel free to take my ack to these
patches:
  Acked-by: Takashi Iwai <tiwai@suse.de>

Or if it's easier through my tree, let me know.


thanks,

Takashi

      parent reply	other threads:[~2016-04-20 13:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20 12:39 [PATCH v5 0/4] Propagate errors out from compressed streams Charles Keepax
2016-04-20 12:40 ` [PATCH v5 1/4] ALSA: compress: Replace complex if statement with switch Charles Keepax
2016-04-20 12:40 ` [PATCH v5 2/4] ALSA: compress: Add function to indicate the stream has gone bad Charles Keepax
2016-04-20 13:08   ` Vinod Koul
2016-04-20 14:54     ` Charles Keepax
2016-04-21  2:25       ` Vinod Koul
2016-04-20 16:10   ` Pierre-Louis Bossart
2016-04-21  8:26     ` Charles Keepax
2016-04-21 12:37       ` Pierre-Louis Bossart
2016-04-20 12:40 ` [PATCH v5 3/4] ASoC: wm_adsp: Use new snd_compr_stop_error to signal stream failure Charles Keepax
2016-04-20 13:09   ` Vinod Koul
2016-04-20 12:40 ` [PATCH v5 4/4] ASoC: compress: Pass error out of soc_compr_pointer Charles Keepax
2016-04-20 13:09 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5htwiw1l6d.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).