From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] Revert "ALSA: hda - Add mute-LED mode
	control to Thinkpad"
Date: Mon, 25 May 2015 08:53:26 +0200
Message-ID: <s5htwv1172x.wl-tiwai@suse.de>
References: <1432449275-29789-1-git-send-email-tiwai@suse.de>
 <CAN8cciYdVa0Ej0koQN1yPCm6SKPPmhtu45V9YOhL2XoZKXHHZA@mail.gmail.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 26434260464
 for <alsa-devel@alsa-project.org>; Mon, 25 May 2015 08:53:27 +0200 (CEST)
In-Reply-To: <CAN8cciYdVa0Ej0koQN1yPCm6SKPPmhtu45V9YOhL2XoZKXHHZA@mail.gmail.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Raymond Yau <superquad.vortex2@gmail.com>
Cc: Martin Steigerwald <martin@lichtvoll.de>, ALSA Development Mailing List <alsa-devel@alsa-project.org>, Pali =?UTF-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
List-Id: alsa-devel@alsa-project.org

At Mon, 25 May 2015 14:44:04 +0800,
Raymond Yau wrote:
> 
> >
> > This reverts commit 7290006d8c0900c56d8c58428134f02c35109d17.
> >
> > Through the regression report, it was revealed that the
> > tpacpi_led_set() call to thinkpad_acpi helper doesn't only toggle the
> > mute LED but actually mutes the sound.  This is contradiction to the
> > expectation, and rather confuses user.
> >
> > According to Henrique, it's not trivial to judge which TP model
> > behaves "LED-only" and which model does whatever more intrusive, as
> > Lenovo's implementations vary model by model.  So, from the safety
> > reason, we should revert the patch for now
> 
> Are there any ThinkPad which known to support mute led through ACPI SSMS ?

The answer is "yes, but..."

There are known Thinkpads that do the audio mute together with LED.
And judging the difference isn't trivial.  It'd need a huge
black/white list, which we want to avoid.


Takashi