From: Takashi Iwai <tiwai@suse.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
han.lu@intel.com, alsa-devel@alsa-project.org
Subject: Re: [PATCH - UCM 1/2] control: enable octal and hexadecimal parse
Date: Tue, 13 Jan 2015 21:01:37 +0100 [thread overview]
Message-ID: <s5htwzu1mce.wl-tiwai@suse.de> (raw)
In-Reply-To: <s5ha91mipvp.wl-tiwai@suse.de>
At Tue, 13 Jan 2015 17:53:14 +0100,
Takashi Iwai wrote:
>
> At Tue, 13 Jan 2015 11:00:38 +0800,
> han.lu@intel.com wrote:
> >
> > From: "Lu, Han" <han.lu@intel.com>
> >
> > Signed-off-by: Lu, Han <han.lu@intel.com>
>
> Looks good to me. Liam, any objection for this extension?
Erm, sorry, I correct my statement: this is buggy. Look at the code:
> > - val = strtol(s, &p, 10);
> > + val = strtol(s, &p, 0);
> > if (*p == '.') {
> > p++;
> > - strtol(p, &p, 10);
> > + strtol(p, &p, 0);
The second strtol() is for skipping the decimals. So this has to be
10-based. That is, use zero-base only for the first strtol().
Takashi
next prev parent reply other threads:[~2015-01-13 20:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 3:00 [PATCH - UCM 1/2] control: enable octal and hexadecimal parse han.lu
2015-01-13 3:00 ` [PATCH - UCM 2/2] ucm: add binary configure file parse han.lu
2015-01-13 16:52 ` Takashi Iwai
2015-01-13 18:26 ` Liam Girdwood
2015-01-13 19:50 ` Takashi Iwai
2015-01-14 11:29 ` Liam Girdwood
2015-01-13 16:53 ` [PATCH - UCM 1/2] control: enable octal and hexadecimal parse Takashi Iwai
2015-01-13 18:21 ` Liam Girdwood
2015-01-13 20:01 ` Takashi Iwai [this message]
2015-01-14 1:28 ` Lu, Han
-- strict thread matches above, loose matches on Subject: below --
2015-01-14 1:08 han.lu
2015-01-14 11:16 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htwzu1mce.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=han.lu@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox