From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: HP mute led for ALC286
Date: Thu, 20 Nov 2014 11:05:50 +0100
Message-ID: <s5htx1uxk3l.wl-tiwai@suse.de>
References: <s5hr3x9qz5j.wl-tiwai@suse.de>
 <6FAB7C47BCF00940BB0999A99BE3547A179FB004@RTITMBSV09.realtek.com.tw>
 <s5h8ujgrext.wl-tiwai@suse.de>
 <6FAB7C47BCF00940BB0999A99BE3547A179FB7CA@RTITMBSV09.realtek.com.tw>
 <s5h8uj71lci.wl-tiwai@suse.de>
 <6FAB7C47BCF00940BB0999A99BE3547A179FB92A@RTITMBSV09.realtek.com.tw>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 3506B2605B4
 for <alsa-devel@alsa-project.org>; Thu, 20 Nov 2014 11:05:51 +0100 (CET)
In-Reply-To: <6FAB7C47BCF00940BB0999A99BE3547A179FB92A@RTITMBSV09.realtek.com.tw>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Kailang <kailang@realtek.com>
Cc: " (alsa-devel@alsa-project.org)" <alsa-devel@alsa-project.org>
List-Id: alsa-devel@alsa-project.org

At Thu, 20 Nov 2014 07:04:01 +0000,
Kailang wrote:
> 
>  
> 
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai@suse.de] 
> > Sent: Wednesday, November 19, 2014 7:28 PM
> > To: Kailang
> > Cc: (alsa-devel@alsa-project.org)
> > Subject: Re: HP mute led for ALC286
> > 
> > At Wed, 19 Nov 2014 07:13:16 +0000,
> > Kailang wrote:
> > > 
> > > Hi Takashi,
> > > 
> > > I had sent the discussion mail about the DMI string for HP.
> > > But no body response.
> > > So, I just send the patch to fix this issue.
> > 
> > I'd like to avoid the duplicated open codes, so could you try 
> > the patch below and rewrite your patch to follow this?  You'd 
> > just need to set like:
> >   spec->gpio_mute_led_mask = 0x02;
> >   spec->gpio_mic_led_mask = 0x20;
> >   pec->mute_led_polarity = 0;
> > then you can use the existing alc_fixup_gpio_mute_hook and 
> > alc_fixup_gpio_mic_mute_hook.
> 
> I modified as attach patch. ^^

Oh, no, I meant an additional patch on top of my previous patch, not
folding into that one.

For your ease, I applied my patch to for-next branch now, so that you
can rewrite the patch to be applicable to there.


thanks,

Takashi