From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 1/1] sound/aoa/codecs/onyx.c: use static
	const	for texts
Date: Tue, 27 May 2014 12:01:03 +0200
Message-ID: <s5htx8bilr4.wl%tiwai@suse.de>
References: <20140527091218.246af6a3346fa67930e41f18@skynet.be>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id BEF5926170F
 for <alsa-devel@alsa-project.org>; Tue, 27 May 2014 12:01:03 +0200 (CEST)
In-Reply-To: <20140527091218.246af6a3346fa67930e41f18@skynet.be>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Fabian Frederick <fabf@skynet.be>
Cc: alsa-devel@alsa-project.org, Johannes Berg <johannes@sipsolutions.net>
List-Id: alsa-devel@alsa-project.org

At Tue, 27 May 2014 09:12:18 +0200,
Fabian Frederick wrote:
> 
> 'texts' is only used as source in strcpy
> 
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiway@suse.de>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Thanks, applied.


Takashi

> ---
> This is untested.
> 
>  sound/aoa/codecs/onyx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c
> index f01bffb..401107b 100644
> --- a/sound/aoa/codecs/onyx.c
> +++ b/sound/aoa/codecs/onyx.c
> @@ -241,7 +241,7 @@ static struct snd_kcontrol_new inputgain_control = {
>  static int onyx_snd_capture_source_info(struct snd_kcontrol *kcontrol,
>  	struct snd_ctl_elem_info *uinfo)
>  {
> -	static char *texts[] = { "Line-In", "Microphone" };
> +	static const char * const texts[] = { "Line-In", "Microphone" };
>  
>  	uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
>  	uinfo->count = 1;
> -- 
> 1.9.1
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>