From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 04/11] ASoC: Add macros for defining virtual enums Date: Mon, 24 Feb 2014 10:29:20 +0100 Message-ID: References: <1393168221-23018-1-git-send-email-lars@metafoo.de> <1393168221-23018-5-git-send-email-lars@metafoo.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 6D746265283 for ; Mon, 24 Feb 2014 10:29:21 +0100 (CET) In-Reply-To: <1393168221-23018-5-git-send-email-lars@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lars-Peter Clausen Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, Liam Girdwood , Mark Brown , Philippe =?UTF-8?B?UsOpdG9ybmF6?= , Charles Keepax , Steffen Trumtrar , Jerry Wong List-Id: alsa-devel@alsa-project.org At Sun, 23 Feb 2014 16:10:14 +0100, Lars-Peter Clausen wrote: > > With the upcoming consolidation of normal MUXs and virtual MUXs we need to be > able to distinguish between enums with and without a backing register at the > enum level. Use the same approach as used for virtual mixer controls by setting > the reg field of the enum to SND_SOC_NOPM for enums without a backing register. > This patch adds a set of helper macros that can be used to define such enums. > > Signed-off-by: Lars-Peter Clausen > --- > include/sound/soc.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/sound/soc.h b/include/sound/soc.h > index e005196..a25de13 100644 > --- a/include/sound/soc.h > +++ b/include/sound/soc.h > @@ -189,6 +189,8 @@ > .mask = xmask, .items = xitems, .texts = xtexts, .values = xvalues} > #define SOC_VALUE_ENUM_SINGLE(xreg, xshift, xmask, xnitmes, xtexts, xvalues) \ > SOC_VALUE_ENUM_DOUBLE(xreg, xshift, xshift, xmask, xnitmes, xtexts, xvalues) > +#define SOC_ENUM_SINGLE_VIRT(xmax, xtexts) \ > + SOC_ENUM_SINGLE(SND_SOC_NOPM, 0, xmax, xtexts) Could you replace "max" with "items"? Takashi