From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 0/3] alsa-lib - improve surround 2.1 support Date: Fri, 21 Feb 2014 16:50:59 +0100 Message-ID: References: <1392996262-27970-1-git-send-email-david.henningsson@canonical.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 301D22658DE for ; Fri, 21 Feb 2014 16:51:00 +0100 (CET) In-Reply-To: <1392996262-27970-1-git-send-email-david.henningsson@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: David Henningsson Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Fri, 21 Feb 2014 16:24:19 +0100, David Henningsson wrote: > > So, in order to support 2.1 surround on both 4-channels (e g FL FR LFE LFE, > on internal subwoofer) and 6-channels (e g FL FR RL RR C LFE, on desktops > with 5.1 out), I needed to make the route plugin more chmap aware. > > This also included allowing a new syntax for the ttable, which I think is > quite nice. The new syntax also falls back to ALSAs standard chmap in case > the hardware does not support it. The idea looks great, a nice improvement. Spotted a few trivial things I posted individually, but in general it's in a good shape. thanks, Takashi > > David Henningsson (3): > route: Allow chmap syntax for slave channels in ttable > route: Select slave chmap based on ttable information > conf: Allow 2.1 surround to use different number of channels > > src/conf/pcm/surround21.conf | 7 +- > src/pcm/pcm_route.c | 304 ++++++++++++++++++++++++++++++++++++++----- > 2 files changed, 271 insertions(+), 40 deletions(-) > > -- > 1.9.0 >