Re: [PATCH 0/9] ALSA: compress offfload fixes

[Takashi Iwai <tiwai@suse.de>]

At Tue, 27 Aug 2013 19:00:30 +0530,
Vinod Koul wrote:
> 
> On Tue, Aug 27, 2013 at 04:05:36PM +0200, Takashi Iwai wrote:
> > At Tue, 27 Aug 2013 18:44:38 +0530,
> > Vinod Koul wrote:
> > > 
> > > On Tue, Aug 27, 2013 at 02:32:28PM +0200, Takashi Iwai wrote:
> > > > > > >  - As disscused on our sample rate problem, lets move to use rate values and I
> > > > > > >    will fix the lib too. Since the driver are not upstream the impact of this
> > > > > > > change wont be huge.
> > > > > > 
> > > > > > I see no code touching sampling_rate field.
> > > > > Yes its passed directly to the drivers, where tehy use values to program
> > > > > decoders. Only meaning of the field is changing now.
> > > > 
> > > > So you're proposing a patch just changing the comment in the header
> > > > file as a stable fix patch?  Please reread stable_kernel_rules.txt
> > > > once again.
> > > Yes along with header version so that tinycompress can cope with it.
> > 
> > I've seen nothing but changing the comment in the patch.
> > What's missing?
> > 
> > > The meaning of the value is changing here... 
> > 
> > Again, is this a bug fix?  Stable patches are only for bug fixes.
> yup... we can't do 12K, 24K decoding without this. We actually found when folks
> tried aac with 12K

I understand it, but my question is what fixes your patch except for
the comment in the header file?  In other words, by changing the
comment text, what will be fixed in the end?


Takashi