Re: [PATCH - microII 1/1] conf/cards: add Audio Advantage Micro II

From: Takashi Iwai <tiwai@suse.de>
To: Przemek Rudy <prudy1@o2.pl>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH - microII 1/1] conf/cards: add Audio Advantage Micro II
Date: Tue, 30 Jul 2013 07:56:10 +0200	[thread overview]
Message-ID: <s5htxjc616t.wl%tiwai@suse.de> (raw)
In-Reply-To: <51F6B49E.5010202@o2.pl>

At Mon, 29 Jul 2013 20:29:50 +0200,
Przemek Rudy wrote:
> 
> Any chances to merge this one?
> I believe it simply got lost among others...

Please resend the whole patche with a detailed changelog in a proper
format.  That is, give a patch that is applicable directly via
git-am.

thanks,

Takashi

> 
> Thanks :)
> Przemek
> 
> On 06/28/2013 01:13 PM, Przemysław Rudy wrote:
> > Please find the following description:
> > 
> > ------------------
> > This patch is adding extensive support (beside standard usb audio class)
> > for Audio Advantage Micro II usb sound card. This patch depends on
> > related kernel patch.
> > Features included:
> > - Add AES bits controls (so they can be accessible via device suffix
> > AESn= as well as via tools like iecset).
> > - SPDIF switch control added to turn on/off the optical transmitter
> > (accessible e.g. via alsamixer tool)
> > ------------------
> > 
> > Best,
> > Przemek
> > 
> > On 2013-06-28 12:11, Takashi Iwai wrote:
> >> At Thu, 27 Jun 2013 23:52:34 +0200,
> >> Przemek Rudy wrote:
> >>>
> >>> Signed-off-by: Przemek Rudy <prudy1@o2.pl>
> >>
> >> Ditto like the kernel patch.  The patch description is one of the most
> >> important things.  Please give it more.
> >>
> >>
> >> thanks,
> >>
> >> Takashi
> >>
> >>>
> >>> diff --git a/src/conf/cards/USB-Audio.conf b/src/conf/cards/USB-Audio.conf
> >>> index 0d93175..8a6d9ca 100644
> >>> --- a/src/conf/cards/USB-Audio.conf
> >>> +++ b/src/conf/cards/USB-Audio.conf
> >>> @@ -101,6 +101,41 @@ USB-Audio."Audiophile USB (tm)".pcm.iec958 {
> >>>  	}
> >>>  }
> >>>  
> >>> +# For this card we can (and must to get IEC61937) set AES bits
> >>> +USB-Audio."MicroII".pcm.iec958 "cards.USB-Audio.Audio Advantage MicroII.pcm.iec958"
> >>> +USB-Audio."Audio Advantage MicroII".pcm.iec958 {
> >>> +	@args [ CARD AES0 AES1 AES2 AES3 ]
> >>> +	@args.CARD { type string }
> >>> +	@args.AES0 { type integer }
> >>> +	@args.AES1 { type integer }
> >>> +	@args.AES2 { type integer }
> >>> +	@args.AES3 { type integer }
> >>> +
> >>> +    type hooks
> >>> +    slave.pcm {
> >>> +		type hw
> >>> +		card $CARD
> >>> +    }
> >>> +
> >>> +    hooks.0 {
> >>> +		type ctl_elems
> >>> +		hook_args [
> >>> +			{
> >>> +				interface PCM
> >>> +				name "IEC958 Playback Default"
> >>> +				preserve true
> >>> +				optional true
> >>> +				value [ $AES0 $AES1 $AES2 $AES3 ]
> >>> +			}
> >>> +			{
> >>> +				name "IEC958 Playback Switch"
> >>> +				lock true
> >>> +				preserve true
> >>> +				value 1
> >>> +			}
> >>> +		]
> >>> +	}
> >>> +}
> >>>  
> >>>  ################################################################################
> >>>  
> >>> -- 
> >>> 1.8.1.4
> >>>
> >> _______________________________________________
> >> Alsa-devel mailing list
> >> Alsa-devel@alsa-project.org
> >> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >>
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> > 
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel