From: Takashi Iwai <tiwai@suse.de>
To: Nitin Daga <ndaga@nvidia.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda: Disable 4/6 channels on some NVIDIA GPUs.
Date: Tue, 11 Jan 2011 20:01:54 +0100 [thread overview]
Message-ID: <s5htyhfi7rx.wl%tiwai@suse.de> (raw)
In-Reply-To: <1294676371-1401-1-git-send-email-ndaga@nvidia.com>
At Mon, 10 Jan 2011 21:49:31 +0530,
Nitin Daga wrote:
>
> Added hardware constraint in patch_hdmi.c to disable
> channels 4/6 which are not supported by some older
> NVIDIA GPUs.
>
> Signed-off-by: Nitin Daga <ndaga@nvidia.com>
> Acked-By: Stephen Warren <swarren@nvidia.com>
Applied now. Thanks.
Takashi
> ---
> pci/hda/patch_hdmi.c | 42 ++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 42 insertions(+), 0 deletions(-)
>
> diff --git a/pci/hda/patch_hdmi.c b/pci/hda/patch_hdmi.c
> index d3e49aa..ddde59b 100644
> --- a/pci/hda/patch_hdmi.c
> +++ b/pci/hda/patch_hdmi.c
> @@ -1166,11 +1166,53 @@ static int nvhdmi_7x_init(struct hda_codec *codec)
> return 0;
> }
>
> +static unsigned int channels_2_6_8[] = {
> + 2, 6, 8
> +};
> +
> +static unsigned int channels_2_8[] = {
> + 2, 8
> +};
> +
> +static struct snd_pcm_hw_constraint_list hw_constraints_2_6_8_channels = {
> + .count = ARRAY_SIZE(channels_2_6_8),
> + .list = channels_2_6_8,
> + .mask = 0,
> +};
> +
> +static struct snd_pcm_hw_constraint_list hw_constraints_2_8_channels = {
> + .count = ARRAY_SIZE(channels_2_8),
> + .list = channels_2_8,
> + .mask = 0,
> +};
> +
> static int simple_playback_pcm_open(struct hda_pcm_stream *hinfo,
> struct hda_codec *codec,
> struct snd_pcm_substream *substream)
> {
> struct hdmi_spec *spec = codec->spec;
> + struct snd_pcm_hw_constraint_list *hw_constraints_channels = NULL;
> +
> + switch (codec->preset->id) {
> + case 0x10de0002:
> + case 0x10de0003:
> + case 0x10de0005:
> + case 0x10de0006:
> + hw_constraints_channels = &hw_constraints_2_8_channels;
> + break;
> + case 0x10de0007:
> + hw_constraints_channels = &hw_constraints_2_6_8_channels;
> + break;
> + default:
> + break;
> + }
> +
> + if (hw_constraints_channels != NULL) {
> + snd_pcm_hw_constraint_list(substream->runtime, 0,
> + SNDRV_PCM_HW_PARAM_CHANNELS,
> + hw_constraints_channels);
> + }
> +
> return snd_hda_multi_out_dig_open(codec, &spec->multiout);
> }
>
> --
> 1.7.0.4
>
>
> -----------------------------------------------------------------------------------
> This email message is for the sole use of the intended recipient(s) and may contain
> confidential information. Any unauthorized review, use, disclosure or distribution
> is prohibited. If you are not the intended recipient, please contact the sender by
> reply email and destroy all copies of the original message.
> -----------------------------------------------------------------------------------
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
prev parent reply other threads:[~2011-01-11 19:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 16:19 [PATCH] ALSA: hda: Disable 4/6 channels on some NVIDIA GPUs Nitin Daga
2011-01-11 17:11 ` Anssi Hannula
2011-01-11 17:41 ` Stephen Warren
2011-01-12 4:11 ` Anssi Hannula
2011-01-12 16:42 ` Stephen Warren
2011-01-12 17:11 ` Anssi Hannula
2011-01-11 19:06 ` Takashi Iwai
2011-01-11 19:01 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htyhfi7rx.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=ndaga@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).