From: Takashi Iwai <tiwai@suse.de>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: snd-atmel-abdac: test wrong variable
Date: Mon, 22 Nov 2010 07:56:41 +0100 [thread overview]
Message-ID: <s5htyj9rgly.wl%tiwai@suse.de> (raw)
In-Reply-To: <1290361209-15121-1-git-send-email-segoon@openwall.com>
At Sun, 21 Nov 2010 20:40:07 +0300,
Vasiliy Kulikov wrote:
>
> After clk_get() pclk is checked second time instead of sample_clk check.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Applied now. Thanks.
Takashi
> ---
> Compile tested only.
>
> sound/atmel/abdac.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c
> index f2f41c8..4e47baa 100644
> --- a/sound/atmel/abdac.c
> +++ b/sound/atmel/abdac.c
> @@ -420,7 +420,7 @@ static int __devinit atmel_abdac_probe(struct platform_device *pdev)
> return PTR_ERR(pclk);
> }
> sample_clk = clk_get(&pdev->dev, "sample_clk");
> - if (IS_ERR(pclk)) {
> + if (IS_ERR(sample_clk)) {
> dev_dbg(&pdev->dev, "no sample clock\n");
> retval = PTR_ERR(pclk);
> goto out_put_pclk;
> --
> 1.7.0.4
>
next prev parent reply other threads:[~2010-11-22 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 17:40 [PATCH] ALSA: snd-atmel-abdac: test wrong variable Vasiliy Kulikov
2010-11-22 6:56 ` Takashi Iwai [this message]
2010-11-22 8:01 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htyj9rgly.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segoon@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox