* Band-aid solution for Dell Latitude E6410/E6510 microphone
@ 2010-09-29 2:09 Diego Elio Pettenò
2010-09-29 2:09 ` [PATCH] ALSA: HDA: Enable internal mic on Dell E6410 and Dell E6510 Diego Elio Pettenò
2010-09-29 6:15 ` Band-aid solution for Dell Latitude E6410/E6510 microphone David Henningsson
0 siblings, 2 replies; 6+ messages in thread
From: Diego Elio Pettenò @ 2010-09-29 2:09 UTC (permalink / raw)
To: linux-kernel, alsa-devel; +Cc: David Henningsson
Hi all,
I'm sending out a patch that I didn't write (and thus most likely require
David's Signed-Off), but which I think might be a good idea to at least
have accessible to search.
As David already pointed out to me, the proper fix for the issue is
Takashi's commit 75e0eb24ee3ec3549c2e53707dcc87e5f7a2c791, but that hasn't
made it into .36 RCs and thus seem unlikely to come to users anytime soon.
David's patch is a "band aid" solution; it solves most of the problem by
adding one more special case to the sigmatel patches; on the other hand it
makes the internal microphone to work fine on my laptop, which is a good
thing, right?
Anyway, if this can be considered for .36 or for some stable branch (*looks
toward Greg hoping for pity*), it would probably make me (and other owners
of such laptops) probably very happy. Especially given that we have enough
trouble with a non-working SDHCI and a not-yet-supported Alps
touchpad/trackpoint combination.
Thanks in advance, whatever the outcome,
--
Diego Elio Pettenò
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ALSA: HDA: Enable internal mic on Dell E6410 and Dell E6510
2010-09-29 2:09 Band-aid solution for Dell Latitude E6410/E6510 microphone Diego Elio Pettenò
@ 2010-09-29 2:09 ` Diego Elio Pettenò
2010-10-21 15:09 ` Diego Elio Pettenò
2010-09-29 6:15 ` Band-aid solution for Dell Latitude E6410/E6510 microphone David Henningsson
1 sibling, 1 reply; 6+ messages in thread
From: Diego Elio Pettenò @ 2010-09-29 2:09 UTC (permalink / raw)
To: linux-kernel, alsa-devel; +Cc: David Henningsson
From: David Henningsson <david.henningsson@canonical.com>
BugLink: http://launchpad.net/bugs/628961
BugLink: http://launchpad.net/bugs/605047
CC: Diego Elio Pettenò <flameeyes@gmail.com>
---
sound/pci/hda/patch_sigmatel.c | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index b8d730c..d2e2706 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -93,6 +93,7 @@ enum {
STAC_92HD83XXX_REF,
STAC_92HD83XXX_PWR_REF,
STAC_DELL_S14,
+ STAC_DELL_E6410,
STAC_92HD83XXX_HP,
STAC_92HD83XXX_MODELS
};
@@ -1632,10 +1633,18 @@ static unsigned int dell_s14_pin_configs[10] = {
0x40f000f0, 0x40f000f0,
};
+/* Deliberately turn off 0x0f (Dock Mic) to make it choose Int Mic instead */
+static unsigned int dell_e6410_pin_configs[10] = {
+ 0x04a11020, 0x0421101f, 0x400000f0, 0x90170110,
+ 0x23011050, 0x40f000f0, 0x400000f0, 0x90a60130,
+ 0x40f000f0, 0x40f000f0,
+};
+
static unsigned int *stac92hd83xxx_brd_tbl[STAC_92HD83XXX_MODELS] = {
[STAC_92HD83XXX_REF] = ref92hd83xxx_pin_configs,
[STAC_92HD83XXX_PWR_REF] = ref92hd83xxx_pin_configs,
[STAC_DELL_S14] = dell_s14_pin_configs,
+ [STAC_DELL_E6410] = dell_e6410_pin_configs,
};
static const char *stac92hd83xxx_models[STAC_92HD83XXX_MODELS] = {
@@ -1643,6 +1652,7 @@ static const char *stac92hd83xxx_models[STAC_92HD83XXX_MODELS] = {
[STAC_92HD83XXX_REF] = "ref",
[STAC_92HD83XXX_PWR_REF] = "mic-ref",
[STAC_DELL_S14] = "dell-s14",
+ [STAC_DELL_E6410] = "dell-e6410",
[STAC_92HD83XXX_HP] = "hp",
};
@@ -1654,6 +1664,10 @@ static struct snd_pci_quirk stac92hd83xxx_cfg_tbl[] = {
"DFI LanParty", STAC_92HD83XXX_REF),
SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x02ba,
"unknown Dell", STAC_DELL_S14),
+ SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x040a,
+ "Dell E6410", STAC_DELL_E6410),
+ SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x040b,
+ "Dell E6510", STAC_DELL_E6410),
SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
"HP", STAC_92HD83XXX_HP),
{} /* terminator */
--
1.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: Band-aid solution for Dell Latitude E6410/E6510 microphone
2010-09-29 2:09 Band-aid solution for Dell Latitude E6410/E6510 microphone Diego Elio Pettenò
2010-09-29 2:09 ` [PATCH] ALSA: HDA: Enable internal mic on Dell E6410 and Dell E6510 Diego Elio Pettenò
@ 2010-09-29 6:15 ` David Henningsson
1 sibling, 0 replies; 6+ messages in thread
From: David Henningsson @ 2010-09-29 6:15 UTC (permalink / raw)
To: Diego Elio Pettenò; +Cc: alsa-devel, linux-kernel
On 2010-09-29 04:09, Diego Elio Pettenò wrote:
> Hi all,
>
> I'm sending out a patch that I didn't write (and thus most likely require
> David's Signed-Off), but which I think might be a good idea to at least
> have accessible to search.
>
> As David already pointed out to me, the proper fix for the issue is
> Takashi's commit 75e0eb24ee3ec3549c2e53707dcc87e5f7a2c791, but that hasn't
> made it into .36 RCs and thus seem unlikely to come to users anytime soon.
>
> David's patch is a "band aid" solution; it solves most of the problem by
> adding one more special case to the sigmatel patches; on the other hand it
> makes the internal microphone to work fine on my laptop, which is a good
> thing, right?
It might also break docking station microphones on the same machines,
which is why I thought it was no use trying to send it to stable. But if
stable wants to add it, I'd be glad to give a sign-off or whatever
necessary.
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ALSA: HDA: Enable internal mic on Dell E6410 and Dell E6510
2010-09-29 2:09 ` [PATCH] ALSA: HDA: Enable internal mic on Dell E6410 and Dell E6510 Diego Elio Pettenò
@ 2010-10-21 15:09 ` Diego Elio Pettenò
2010-10-21 21:28 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Diego Elio Pettenò @ 2010-10-21 15:09 UTC (permalink / raw)
To: linux-kernel, alsa-devel; +Cc: David Henningsson
From: David Henningsson <david.henningsson@canonical.com>
(Ported on top of 2.6.36)
BugLink: http://launchpad.net/bugs/628961
BugLink: http://launchpad.net/bugs/605047
CC: Diego Elio Pettenò <flameeyes@gmail.com>
---
sound/pci/hda/patch_sigmatel.c | 13 +++++++++++++
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index c16c5ba..be79c3c 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -1633,6 +1633,13 @@ static unsigned int dell_s14_pin_configs[10] = {
0x40f000f0, 0x40f000f0,
};
+/* Deliberately turn off 0x0f (Dock Mic) to make it choose Int Mic instead */
+static unsigned int dell_e6410_pin_configs[10] = {
+ 0x04a11020, 0x0421101f, 0x400000f0, 0x90170110,
+ 0x23011050, 0x40f000f0, 0x400000f0, 0x90a60130,
+ 0x40f000f0, 0x40f000f0,
+};
+
static unsigned int hp_dv7_4000_pin_configs[10] = {
0x03a12050, 0x0321201f, 0x40f000f0, 0x90170110,
0x40f000f0, 0x40f000f0, 0x90170110, 0xd5a30140,
@@ -1643,6 +1650,7 @@ static unsigned int *stac92hd83xxx_brd_tbl[STAC_92HD83XXX_MODELS] = {
[STAC_92HD83XXX_REF] = ref92hd83xxx_pin_configs,
[STAC_92HD83XXX_PWR_REF] = ref92hd83xxx_pin_configs,
[STAC_DELL_S14] = dell_s14_pin_configs,
+ [STAC_DELL_E6410] = dell_e6410_pin_configs,
[STAC_HP_DV7_4000] = hp_dv7_4000_pin_configs,
};
@@ -1651,6 +1659,7 @@ static const char *stac92hd83xxx_models[STAC_92HD83XXX_MODELS] = {
[STAC_92HD83XXX_REF] = "ref",
[STAC_92HD83XXX_PWR_REF] = "mic-ref",
[STAC_DELL_S14] = "dell-s14",
+ [STAC_DELL_E6410] = "dell-e6410",
[STAC_92HD83XXX_HP] = "hp",
[STAC_HP_DV7_4000] = "hp-dv7-4000",
};
@@ -1663,6 +1672,10 @@ static struct snd_pci_quirk stac92hd83xxx_cfg_tbl[] = {
"DFI LanParty", STAC_92HD83XXX_REF),
SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x02ba,
"unknown Dell", STAC_DELL_S14),
+ SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x040a,
+ "Dell E6410", STAC_DELL_E6410),
+ SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x040b,
+ "Dell E6510", STAC_DELL_E6410),
SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
"HP", STAC_92HD83XXX_HP),
{} /* terminator */
--
1.7.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: HDA: Enable internal mic on Dell E6410 and Dell E6510
2010-10-21 15:09 ` Diego Elio Pettenò
@ 2010-10-21 21:28 ` Takashi Iwai
2010-10-24 1:56 ` David Henningsson
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2010-10-21 21:28 UTC (permalink / raw)
To: Diego Elio Pettenò; +Cc: alsa-devel, linux-kernel, David Henningsson
At Thu, 21 Oct 2010 17:09:49 +0200,
Diego Elio Pettenò wrote:
>
> From: David Henningsson <david.henningsson@canonical.com>
>
> (Ported on top of 2.6.36)
>
> BugLink: http://launchpad.net/bugs/628961
> BugLink: http://launchpad.net/bugs/605047
>
> CC: Diego Elio Pettenò <flameeyes@gmail.com>
I'd need sign-offs of you and David.
Could you guys give them?
Takashi
> ---
> sound/pci/hda/patch_sigmatel.c | 13 +++++++++++++
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index c16c5ba..be79c3c 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -1633,6 +1633,13 @@ static unsigned int dell_s14_pin_configs[10] = {
> 0x40f000f0, 0x40f000f0,
> };
>
> +/* Deliberately turn off 0x0f (Dock Mic) to make it choose Int Mic instead */
> +static unsigned int dell_e6410_pin_configs[10] = {
> + 0x04a11020, 0x0421101f, 0x400000f0, 0x90170110,
> + 0x23011050, 0x40f000f0, 0x400000f0, 0x90a60130,
> + 0x40f000f0, 0x40f000f0,
> +};
> +
> static unsigned int hp_dv7_4000_pin_configs[10] = {
> 0x03a12050, 0x0321201f, 0x40f000f0, 0x90170110,
> 0x40f000f0, 0x40f000f0, 0x90170110, 0xd5a30140,
> @@ -1643,6 +1650,7 @@ static unsigned int *stac92hd83xxx_brd_tbl[STAC_92HD83XXX_MODELS] = {
> [STAC_92HD83XXX_REF] = ref92hd83xxx_pin_configs,
> [STAC_92HD83XXX_PWR_REF] = ref92hd83xxx_pin_configs,
> [STAC_DELL_S14] = dell_s14_pin_configs,
> + [STAC_DELL_E6410] = dell_e6410_pin_configs,
> [STAC_HP_DV7_4000] = hp_dv7_4000_pin_configs,
> };
>
> @@ -1651,6 +1659,7 @@ static const char *stac92hd83xxx_models[STAC_92HD83XXX_MODELS] = {
> [STAC_92HD83XXX_REF] = "ref",
> [STAC_92HD83XXX_PWR_REF] = "mic-ref",
> [STAC_DELL_S14] = "dell-s14",
> + [STAC_DELL_E6410] = "dell-e6410",
> [STAC_92HD83XXX_HP] = "hp",
> [STAC_HP_DV7_4000] = "hp-dv7-4000",
> };
> @@ -1663,6 +1672,10 @@ static struct snd_pci_quirk stac92hd83xxx_cfg_tbl[] = {
> "DFI LanParty", STAC_92HD83XXX_REF),
> SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x02ba,
> "unknown Dell", STAC_DELL_S14),
> + SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x040a,
> + "Dell E6410", STAC_DELL_E6410),
> + SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x040b,
> + "Dell E6510", STAC_DELL_E6410),
> SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
> "HP", STAC_92HD83XXX_HP),
> {} /* terminator */
> --
> 1.7.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: HDA: Enable internal mic on Dell E6410 and Dell E6510
2010-10-21 21:28 ` Takashi Iwai
@ 2010-10-24 1:56 ` David Henningsson
0 siblings, 0 replies; 6+ messages in thread
From: David Henningsson @ 2010-10-24 1:56 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, Diego Elio Pettenò
On 2010-10-21 23:28, Takashi Iwai wrote:
> At Thu, 21 Oct 2010 17:09:49 +0200,
> Diego Elio Pettenò wrote:
>>
>> From: David Henningsson<david.henningsson@canonical.com>
>>
>> (Ported on top of 2.6.36)
>>
>> BugLink: http://launchpad.net/bugs/628961
>> BugLink: http://launchpad.net/bugs/605047
>>
>> CC: Diego Elio Pettenò<flameeyes@gmail.com>
>
> I'd need sign-offs of you and David.
> Could you guys give them?
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Please note that
1) This will enable the internal mic, but disable the dock mic (if any)
at the same time
2) sound-2.6 has a more stable solution as it allows more than one mic
per position in the array, so this should not go into sound-2.6.
These were the reasons I did not send it here originally, as my guess
was that you wouldn't accept it. But feel free to add it into 2.6.36 if
you like.
>
>
> Takashi
>
>> ---
>> sound/pci/hda/patch_sigmatel.c | 13 +++++++++++++
>> 1 files changed, 13 insertions(+), 0 deletions(-)
>>
>> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
>> index c16c5ba..be79c3c 100644
>> --- a/sound/pci/hda/patch_sigmatel.c
>> +++ b/sound/pci/hda/patch_sigmatel.c
>> @@ -1633,6 +1633,13 @@ static unsigned int dell_s14_pin_configs[10] = {
>> 0x40f000f0, 0x40f000f0,
>> };
>>
>> +/* Deliberately turn off 0x0f (Dock Mic) to make it choose Int Mic instead */
>> +static unsigned int dell_e6410_pin_configs[10] = {
>> + 0x04a11020, 0x0421101f, 0x400000f0, 0x90170110,
>> + 0x23011050, 0x40f000f0, 0x400000f0, 0x90a60130,
>> + 0x40f000f0, 0x40f000f0,
>> +};
>> +
>> static unsigned int hp_dv7_4000_pin_configs[10] = {
>> 0x03a12050, 0x0321201f, 0x40f000f0, 0x90170110,
>> 0x40f000f0, 0x40f000f0, 0x90170110, 0xd5a30140,
>> @@ -1643,6 +1650,7 @@ static unsigned int *stac92hd83xxx_brd_tbl[STAC_92HD83XXX_MODELS] = {
>> [STAC_92HD83XXX_REF] = ref92hd83xxx_pin_configs,
>> [STAC_92HD83XXX_PWR_REF] = ref92hd83xxx_pin_configs,
>> [STAC_DELL_S14] = dell_s14_pin_configs,
>> + [STAC_DELL_E6410] = dell_e6410_pin_configs,
>> [STAC_HP_DV7_4000] = hp_dv7_4000_pin_configs,
>> };
>>
>> @@ -1651,6 +1659,7 @@ static const char *stac92hd83xxx_models[STAC_92HD83XXX_MODELS] = {
>> [STAC_92HD83XXX_REF] = "ref",
>> [STAC_92HD83XXX_PWR_REF] = "mic-ref",
>> [STAC_DELL_S14] = "dell-s14",
>> + [STAC_DELL_E6410] = "dell-e6410",
>> [STAC_92HD83XXX_HP] = "hp",
>> [STAC_HP_DV7_4000] = "hp-dv7-4000",
>> };
>> @@ -1663,6 +1672,10 @@ static struct snd_pci_quirk stac92hd83xxx_cfg_tbl[] = {
>> "DFI LanParty", STAC_92HD83XXX_REF),
>> SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x02ba,
>> "unknown Dell", STAC_DELL_S14),
>> + SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x040a,
>> + "Dell E6410", STAC_DELL_E6410),
>> + SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x040b,
>> + "Dell E6510", STAC_DELL_E6410),
>> SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
>> "HP", STAC_92HD83XXX_HP),
>> {} /* terminator */
>> --
>> 1.7.3.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-24 1:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-29 2:09 Band-aid solution for Dell Latitude E6410/E6510 microphone Diego Elio Pettenò
2010-09-29 2:09 ` [PATCH] ALSA: HDA: Enable internal mic on Dell E6410 and Dell E6510 Diego Elio Pettenò
2010-10-21 15:09 ` Diego Elio Pettenò
2010-10-21 21:28 ` Takashi Iwai
2010-10-24 1:56 ` David Henningsson
2010-09-29 6:15 ` Band-aid solution for Dell Latitude E6410/E6510 microphone David Henningsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).