From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: PATCH - ESI Juli driver Date: Mon, 17 Mar 2008 10:24:37 +0100 Message-ID: References: <47DD1934.3000003@insite.cz> <47DE328D.1080009@insite.cz> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id A93312443A for ; Mon, 17 Mar 2008 10:24:37 +0100 (CET) In-Reply-To: <47DE328D.1080009@insite.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Pavel Hofman Cc: ALSA development , Rainer Zimmermann List-Id: alsa-devel@alsa-project.org At Mon, 17 Mar 2008 09:57:49 +0100, Pavel Hofman wrote: > > Takashi Iwai wrote: > > At Sun, 16 Mar 2008 13:57:24 +0100, > > Pavel Hofman wrote: > >> Hi Takashi, > > > > I feel there are too many additional callbacks in your patch. > > Since we don't need too subtle tuning, can we simplify this? > > There are only two callbacks which Juli does not redefine. These could > be removed. Though I felt it was cleaner to have all the clock-specific > stuff potentially redefinable for other cards. > > I did not want to copy/paste any algorithmical code from ice1724.c to > juli.c as it complicates future maintenance. Now, the vt1724 code in > ice1724.c is pretty much about general algorhitms, specific routines are > in stdclock_... I tested the original clock with Prodigy192 which > provided testing analog/SPDIF signals. There are no functional changes. I see the point that you want to make it generic. But, too many callbacks, in other words, too many tuning parameters make the code difficult to follow. It's a question of balance. Takashi