From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] 1616(M) cardbus improvements
Date: Tue, 27 Nov 2007 17:45:46 +0100
Message-ID: <s5htzn7iqmd.wl%tiwai@suse.de>
References: <200711160007.00300.c.fertr@gmail.com>
	<s5hwss3iqqu.wl%tiwai@suse.de>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (ns2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id 0B20D2448F
	for <alsa-devel@alsa-project.org>; Tue, 27 Nov 2007 18:14:50 +0100 (CET)
In-Reply-To: <s5hwss3iqqu.wl%tiwai@suse.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Ctirad Fertr <c.fertr@gmail.com>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Tue, 27 Nov 2007 17:43:05 +0100,
I wrote:
> 
> At Fri, 16 Nov 2007 00:07:00 +0100,
> Ctirad Fertr wrote:
> > 
> > Hello,
> > 
> > this patch improves E-Mu 1616(M) cardbus support. It adds definitions of the 
> > new Microdock and 1010 cardbus registers (thanks again for descriptions 
> > James) and improves mixer for this card. Now you can use S/PDIF and ADAT on 
> > Mirodock and also use headpohone output on host cardbus card as another 
> > independent output.
> > 
> > Signed-off-by: Ctirad Fertr <c.fertr@gmail.com> 
> 
> The changes look almost good to me.  But, if I understand correctly,
> the input source put isn't changed properly for EMU1616.
> 
> The patch below is the revised version with bunch of coding style
> fixes (at the next time, try scripts/checkpatch.pl in linux kernel
> tree before submission).
> Let me know if it works for you.  I'll apply to ALSA tree after your
> confirmation. 
> 
> 
> Thanks,
> 
> Takashi

Oh, BTW, it'd be also appreciated if you can write an additional patch
to add enum definitions for each emu_model type instead of digits.
"if (emu_model == 3)" is no good style.


Thanks,

Takashi