Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: martin-langer@gmx.de
Cc: alsa-devel@lists.sourceforge.net,
	Orm Finnendahl <finnendahl@folkwang-hochschule.de>
Subject: Re: RME installation problems
Date: Thu, 13 Feb 2003 12:13:46 +0100	[thread overview]
Message-ID: <s5hu1f8l9g5.wl@alsa2.suse.de> (raw)
In-Reply-To: <20030213110851.GA3246@tuba.home>

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]

At Thu, 13 Feb 2003 12:08:51 +0100,
Martin Langer wrote:
> 
> On Thu, Feb 13, 2003 at 11:44:24AM +0100, Orm Finnendahl wrote:
> > Hi Takashi,
> > 
> > Am Donnerstag, den 13. Februar 2003 um 10:31:09 Uhr (+0100) schrieb
> > Takashi Iwai:
> > 
> > > > > 
> > > > > ie add the 0xb revision.
> > >
> > > i don't see the mails on ML, so not 100% sure how to fix (although i
> > > guess above mentioned to add the new revision in the check in
> > > snd_rme9652_create()...) 
> > 
> > Yes. In the old driver it just checks for 0xa and 0x64. Just add a
> > line to also check for 0xb.
> > 
> 
> it's in hdsp, not rme9652!

yeah, slipped finger :)
but i don't see any 0x64 there...


anyway, check the attached patch.  is it correct?


Takashi

[-- Attachment #2: hdsp-id-fix.dif --]
[-- Type: application/octet-stream, Size: 523 bytes --]

Index: alsa-kernel/pci/rme9652/hdsp.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/rme9652/hdsp.c,v
retrieving revision 1.20
diff -u -r1.20 hdsp.c
--- alsa-kernel/pci/rme9652/hdsp.c	7 Feb 2003 09:18:41 -0000	1.20
+++ alsa-kernel/pci/rme9652/hdsp.c	13 Feb 2003 11:12:26 -0000
@@ -2981,6 +2981,7 @@
 	
 	switch (rev & 0xff) {
 	case 0xa:
+	case 0xb:
 		/* hdsp_initialize_firmware() will reset this */
 		hdsp->card_name = "RME Hammerfall DSP";
 		break;

  reply	other threads:[~2003-02-13 11:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-12 18:30 RME installation problems Orm Finnendahl
     [not found] ` <1045076338.1544.3.camel@lotte>
2003-02-12 19:12   ` Orm Finnendahl
     [not found]     ` <1045078205.1545.29.camel@lotte>
2003-02-12 20:07       ` Orm Finnendahl
2003-02-13  9:31         ` Takashi Iwai
2003-02-13 10:44           ` Orm Finnendahl
2003-02-13 11:08             ` Martin Langer
2003-02-13 11:13               ` Takashi Iwai [this message]
2003-02-13 13:18                 ` Martin Langer
2003-02-13 15:51                   ` Justin Cormack
2003-02-14  9:34                     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hu1f8l9g5.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=finnendahl@folkwang-hochschule.de \
    --cc=martin-langer@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox