From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECAE8C4707A for ; Sun, 23 May 2021 09:13:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53BB261074 for ; Sun, 23 May 2021 09:13:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53BB261074 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7E3B916B8; Sun, 23 May 2021 11:12:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7E3B916B8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621761205; bh=NEtm7v9sxbGlW/An/nZUM/Ns6Za1WVRy6KQJfBKrYaU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XWTVbAbxrvXJ9xKILYUm5YyKLzbxJROaUS/EZtPS8q6WBrGX1xQuTA6mty2ydaaoW dpyoWf5Y3C5kZ2j7ylHNXMJBNqQ4tl47XvkzGlqIAFqeO8jL8QbH31LxZUkEgFTBk8 vryinms5VrkI5JaGtA+CskI0mv+rTtOdhvxta0zg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 05793F804D1; Sun, 23 May 2021 11:10:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 590F9F804D9; Sun, 23 May 2021 11:10:28 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 90FB1F804D1 for ; Sun, 23 May 2021 11:10:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 90FB1F804D1 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="u47BRC3l"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="mqmuc8bV" X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621761022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ma3TePPD3C6PIzvQPy11xoD26L6g26LJoFyp7EVJAVw=; b=u47BRC3lYrJ7Gic7bbnR+oD/pbkdDwJZz27mLzR75mX5h4En+DhUi3ChqrQ+Cl8yc4OEq2 nzEhJH2Y0Ep+xNoRUpiIHCXcHrAFeCxvNwCtdaHeiLYm+/ve0tkITuDNAirH6ozriahufg Qv98p5ma7a3NF8rYPhqV/A8qATCdJqo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621761022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ma3TePPD3C6PIzvQPy11xoD26L6g26LJoFyp7EVJAVw=; b=mqmuc8bVsLwZedWMPzG6ZputDmUWUXaNHlogkzj2Y4jbk8lZerBybD4cL4AAkDQVPl1PRi aJLJrXTMHWQFz8BA== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 57FEAAAFD; Sun, 23 May 2021 09:10:22 +0000 (UTC) Date: Sun, 23 May 2021 11:10:22 +0200 Message-ID: From: Takashi Iwai To: "Geoffrey D. Bennett" Subject: Re: [RFC PATCH sound] ALSA: usb-audio: scarlett2: snd_scarlett_gen2_controls_create() can be static In-Reply-To: <20210523090326.GA121080@m.b4.vu> References: <202105230212.9rlkrDHb-lkp@intel.com> <20210522180900.GA83915@f59a3af2f1d9> <20210523090326.GA121080@m.b4.vu> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 23 May 2021 11:03:26 +0200, Geoffrey D. Bennett wrote: > > Hi Takashi, > > This patch seems legitimate to me (although I would adjust whitespace > so the second line doesn't go over 80 chars). Do you want to just > apply it as-is, or do you want me to send a second version of my patch > without this problem or send a new patch similar to this one? As it's an obviously correct patch, I already applied as is. thanks, Takashi > > Also sorry I don't know what the etiquette is in cc's for this message > :(. The message from kernel test robot was sent to a lot of people who > I don't think would be interested in this, so I trimmed the cc list > down. > > Thanks, > Geoffrey. > > On Sun, May 23, 2021 at 02:09:00AM +0800, kernel test robot wrote: > > sound/usb/mixer_scarlett_gen2.c:2000:5: warning: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static? > > > > Fixes: 265d1a90e4fb ("ALSA: usb-audio: scarlett2: Improve driver startup messages") > > Reported-by: kernel test robot > > Signed-off-by: kernel test robot > > --- > > mixer_scarlett_gen2.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen2.c > > index 3ad8f61a2095f..4caf379d5b991 100644 > > --- a/sound/usb/mixer_scarlett_gen2.c > > +++ b/sound/usb/mixer_scarlett_gen2.c > > @@ -1997,8 +1997,8 @@ static int scarlett2_mixer_status_create(struct usb_mixer_interface *mixer) > > return usb_submit_urb(mixer->urb, GFP_KERNEL); > > } > > > > -int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer, > > - const struct scarlett2_device_info *info) > > +static int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer, > > + const struct scarlett2_device_info *info) > > { > > int err; > > >