From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BFA6C433ED for ; Fri, 14 May 2021 07:48:10 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E04E6141E for ; Fri, 14 May 2021 07:48:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E04E6141E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 74926178D; Fri, 14 May 2021 09:47:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 74926178D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1620978487; bh=SPwE1vH3sLfDC8v3Er05x8ge00fZRPiCMPw4C5ALB+A=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GhbAbIPjO7McD2M3uN6vLBrEsB+NKt6Q5WWfKcenUQBilVf4Ao2XswAi9GtBXC8IP AK6Sq0uogpHtJsbJaTU4zCfOftQCYWvjn+qGm7tJ48bueof+467wMBpXqAR3iOHNRI KizCWOoTr04Bw7ya9H7bC51qyfTFcNRpqO1JrFko= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 165E1F8020C; Fri, 14 May 2021 09:47:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 23AC5F8026F; Fri, 14 May 2021 09:47:16 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D75B3F8013A for ; Fri, 14 May 2021 09:47:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D75B3F8013A X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9ABC9B14A; Fri, 14 May 2021 07:47:09 +0000 (UTC) Date: Fri, 14 May 2021 09:47:09 +0200 Message-ID: From: Takashi Iwai To: YueHaibing Subject: Re: [PATCH -next] ALSA: gus: Replace unsafe strcpy() with strscpy() In-Reply-To: <20210514070507.16600-1-yuehaibing@huawei.com> References: <20210514070507.16600-1-yuehaibing@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: gregkh@linuxfoundation.org, alsa-devel@alsa-project.org, tiwai@suse.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 14 May 2021 09:05:07 +0200, YueHaibing wrote: > > Fix smatch warning: > sound/isa/gus/gus_main.c:396 snd_gus_check_version() error: > strcpy() 'card->longname' too large for 'card->shortname' (80 vs 32) > > Even if this is not a real bug since the longest length of card->longname > now is 31, replace strcpy() with strscpy() in order to avoid possible > future mistake. > > Signed-off-by: YueHaibing Applied, thanks. Takashi