From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDB16C433DB for ; Mon, 1 Mar 2021 13:59:17 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B59E864EAE for ; Mon, 1 Mar 2021 13:59:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B59E864EAE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DC5B4166A; Mon, 1 Mar 2021 14:58:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DC5B4166A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614607155; bh=tGNgJDxqspvsr0dQh5pybJhOA/yg7K6NS7bEd73wpdY=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pzW42YDlRP+0R9ZPDsfDLgY3qbGx8RDeXBwGQyY1oWhL+SnSEYjs5iTnkgkKIJ4Ez qQOlsPRKy/jrb1Pp+uMvo7hfXNL6O4vZzo8IWsF79FkfXnYhEDQfKg3gHmgwcOkh0q tn58gDgXYylAXKTPqi08z+5XyN6gBdrlKkK7fpQY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 71987F804AB; Mon, 1 Mar 2021 14:58:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 67665F80475; Mon, 1 Mar 2021 14:58:23 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4EBAEF80475 for ; Mon, 1 Mar 2021 14:58:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4EBAEF80475 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8A9FDAC24; Mon, 1 Mar 2021 13:58:15 +0000 (UTC) Date: Mon, 01 Mar 2021 14:58:15 +0100 Message-ID: From: Takashi Iwai To: Nicolas MURE Subject: Re: [PATCH 3/4] ALSA: usb-audio: Configure Pioneer DJM-850 samplerate In-Reply-To: <20210226133429.20081-4-nicolas.mure2019@gmail.com> References: <20210226133429.20081-1-nicolas.mure2019@gmail.com> <20210226133429.20081-4-nicolas.mure2019@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, livvy@base.nu X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 26 Feb 2021 14:34:28 +0100, Nicolas MURE wrote: > > Send an `URB_CONTROL out` USB frame to the device to configure its > samplerate. This should be done before using the device for audio > streaming (capture or playback). > > About the change of `usb_rcvctrlpipe` to `usb_sndctrlpipe`, I reached > the author of this line and she agrees about this change. Control frames > to set device options should have the `out` direction instead of the `in` > direction. This specific fix should be applied separately for 5.12. Could you split this one and submit as an individual fix? I'm currently thinking of merging the rest for 5.13, as 5.12 merge window was already closed. thanks, Takashi > > See https://github.com/nm2107/Pioneer-DJM-850-driver-reverse-engineering > /blob/172fb9a61055960c88c67b7c416fe5bf3609807b > /doc/windows-dvs/framerate-setting/README.md > > Signed-off-by: Nicolas MURE > --- > sound/usb/quirks.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c > index 9ba4682ebc48..d02dac5fcd40 100644 > --- a/sound/usb/quirks.c > +++ b/sound/usb/quirks.c > @@ -1482,7 +1482,7 @@ static int pioneer_djm_set_format_quirk(struct snd_usb_substream *subs, > usb_set_interface(subs->dev, 0, 1); > // we should derive windex from fmt-sync_ep but it's not set > snd_usb_ctl_msg(subs->stream->chip->dev, > - usb_rcvctrlpipe(subs->stream->chip->dev, 0), > + usb_sndctrlpipe(subs->stream->chip->dev, 0), > 0x01, 0x22, 0x0100, windex, &sr, 0x0003); > return 0; > } > @@ -1503,6 +1503,9 @@ void snd_usb_set_format_quirk(struct snd_usb_substream *subs, > case USB_ID(0x2b73, 0x0013): /* Pioneer DJM-450 */ > pioneer_djm_set_format_quirk(subs, 0x0082); > break; > + case USB_ID(0x08e4, 0x0163): /* Pioneer DJM-850 */ > + pioneer_djm_set_format_quirk(subs, 0x0086); > + break; > } > } > > -- > 2.29.2 >