From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29672C433E0 for ; Tue, 23 Feb 2021 16:21:46 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61B6664E5C for ; Tue, 23 Feb 2021 16:21:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61B6664E5C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B760F1668; Tue, 23 Feb 2021 17:20:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B760F1668 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614097303; bh=/ybN3WkEKDkgPg72+98wLmUtx9FvufBOG51pmr1+irI=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=n9eVFE4ZRgwJ3nUaSpkNk31TPCVBCOwWvGox1c3rVnngOAH6J7hIn6T2da4KQe2l2 /9w4cFYX8ErwFBomlxQ0PKjvqFVPa1s1bSnxtu//8JLHcWaBwSR5aieMCODJBiit9o OpSX8Yc1gqDEqReRgTzYupy7U1WjzhzqafyBxfzM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3C66EF80167; Tue, 23 Feb 2021 17:20:53 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3BE07F80169; Tue, 23 Feb 2021 17:20:51 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D6480F800B4 for ; Tue, 23 Feb 2021 17:20:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D6480F800B4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D655BAC6E; Tue, 23 Feb 2021 16:20:41 +0000 (UTC) Date: Tue, 23 Feb 2021 17:20:41 +0100 Message-ID: From: Takashi Iwai To: Jaroslav Kysela Subject: Re: [RFC 2/2] ASoC: rt5670: Add LED trigger support In-Reply-To: References: <20210215142419.308651-1-hdegoede@redhat.com> <20210215142419.308651-3-hdegoede@redhat.com> <20210223134506.GF5116@sirena.org.uk> <578b1ee3-f426-c5b5-bc78-5a91108ebdc8@redhat.com> <20210223140930.GH5116@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Oder Chiou , alsa-devel@alsa-project.org, Liam Girdwood , Hans de Goede , Mark Brown , Bard Liao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 23 Feb 2021 17:14:32 +0100, Jaroslav Kysela wrote: > > Dne 23. 02. 21 v 15:21 Takashi Iwai napsal(a): > > On Tue, 23 Feb 2021 15:09:30 +0100, > > Mark Brown wrote: > >> > >> On Tue, Feb 23, 2021 at 02:59:17PM +0100, Hans de Goede wrote: > >>> On 2/23/21 2:45 PM, Mark Brown wrote: > >>>> On Mon, Feb 15, 2021 at 03:24:19PM +0100, Hans de Goede wrote: > >> > >>>> Why just these particular controls - what if a system has separate mutes > >>>> for speakers or something? > >> > >>> These are the main volume controls, which are always in the output / input > >>> path independent on if we are outputting to e.g. speakers or the headphones. > >> > >>> We want to use the main volume control for this, because there always is > >>> only 1 output mute LED and 1 input mute LED. Well at least that is the assumption > >>> the current ledtrig-audio.c code has. > >> > >>> The idea is to only turn the single LED on if we are sure there will be not > >>> sound output on any of the outputs, which is why we tie the LED to the > >>> mute switch on the main volume control. > >> > >> Right, so that might work well on your particular system with your > >> particular configuration but will it work well on other systems with > >> different hardware? It's not clear to me that it makes sense to go > >> through all the drivers picking controls that might be used for this > >> purpose - it seems both time consuming and error prone. Consider a > >> mostly digital device which has an ADC/DAC per input/output rather than > >> a central ADC/DAC with analogue muxing for example, or a system with > >> multiple DACs available for mixing together or analogue bypassess. > > > > That's one of my concerns in the recent actions for putting the > > hard-coded mute LED controls. So far, the only usage of led-audio > > trigger is HD-audio, and it's enabled only for selected devices and > > setups. OTOH, if we apply the audio-led trigger generically in ASoC > > codec driver, it's always done and might misfit; e.g. what happens if > > two codecs are present on the system?. > > That's the abstraction issue. We can use PCI, ACPI, DMI or DT checks at the > _right_ place (machine top-level code) to mark those controls with the LED > flags in the kernel space. I've never said that the right place is the generic > ASoC codec driver. > > On the other hand, rt5670 is really multi-purpose codec like HDA codecs with > the recommended usage/routing from the designer, so it might make sense to add > the default LED marking as we do for HDA. So do you mean that the LED feature should be selectively enabled like the current HD-audio? > > Of course, this implementation would make the integration much easier, > > and that's a big benefit. So I have a mixed feeling and not decided > > yet whether we should go for it right now... > > I think that we can reconsider the LED handling implementation later, when > someone brings something better on the table. What worried me is the plan to expose this capability to user-space. If it's only a kernel-internal, we can fix it in the kernel and nothing else broken, but if it's a part of API, that's not easy. So, if any, I'd like to avoid exposing to the user-space at first. (But then it comes to the question how to deal with a case like AMD ACP...) thanks, Takashi