From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFCD6C433DF for ; Sun, 14 Jun 2020 09:55:16 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D82F20578 for ; Sun, 14 Jun 2020 09:55:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="GuAN+CGa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D82F20578 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BFB7215E5; Sun, 14 Jun 2020 11:54:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BFB7215E5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1592128514; bh=T1LSlLOKPFN6J9nTzTK4ZtloC1uV177W6hENUvW7Zeg=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GuAN+CGa4eQaiDJM95WzXh6GmE4SIjJzhh3mdU0E+RbcBFeswwmqlh4qiIDoiMdnm f89sb+cSipAAXVwZECk1AJzOwahxJ1WJVZUvXS7NYYgmOtSQp2CmFaoBUSw77w3QFa p99ZOb/aeow1z1iMj3fv5o51H11ShfG8gKZjfWrA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5D3F0F80217; Sun, 14 Jun 2020 11:54:24 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 07020F8022B; Sun, 14 Jun 2020 11:54:23 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 77110F800CD for ; Sun, 14 Jun 2020 11:54:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 77110F800CD X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C8C2EAB8F; Sun, 14 Jun 2020 09:54:22 +0000 (UTC) Date: Sun, 14 Jun 2020 11:54:18 +0200 Message-ID: From: Takashi Iwai To: "Alex Xu (Hello71)" Subject: Re: next-0519 on thinkpad x60: sound related? window manager crash In-Reply-To: <1592065395.r5zwoblr15.none@localhost> References: <20200520111136.GA3802@amd> <1591545088.74ii116nf2.none@localhost> <20200608061950.GA17476@lst.de> <1591624340.z01ejtod28.none@localhost> <20200609114733.GA1621@lst.de> <1592065395.r5zwoblr15.none@localhost> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, x86@kernel.org, rientjes@google.com, tiwai@suse.com, linux-kernel@vger.kernel.org, hch@infradead.org, mingo@redhat.com, bp@alien8.de, Pavel Machek , hpa@zytor.com, tglx@linutronix.de, Christoph Hellwig X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 13 Jun 2020 18:25:22 +0200, Alex Xu (Hello71) wrote: > > Excerpts from Takashi Iwai's message of June 11, 2020 1:11 pm: > > Thanks, so something still missing in the mmap handling, I guess. > > > > I've worked on two different branches for potential fixes of your > > problems. Could you test topic/dma-fix and topic/dma-fix2 branches? > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > > Just pull one of them onto Linus' git HEAD. > > > > I guess we'll go with David's new patch, but still it's interesting > > whether my changes do anything good actually. > > > > > > Takashi > > > > On torvalds 623f6dc593, topic/dma-fix causes sound to be output as > alternating half-second bursts of noise and a few seconds of silence. > topic/dma-fix2 appears to work properly. OK, thanks for the feedback! Just to make sure, you're using PulseAudio, right? If so, it was still something wrong about mmap, and the secondary method (the fallback to the continuous page) looks like a safer approach in the end. I suppose that David's fix will be merged sooner or later. Meanwhile I'll work on the change in the sound driver side to make things a bit more robust. They don't conflict and both good applicable. thanks, Takashi