From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B62CC54FD0 for ; Mon, 27 Apr 2020 14:06:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8DFA2064C for ; Mon, 27 Apr 2020 14:06:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="d5XG82UY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8DFA2064C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 05C9D167F; Mon, 27 Apr 2020 16:05:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 05C9D167F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587996399; bh=xocaWQi737FNUDH/M7o8zL3tThKIFWhQdU4IYcFxvnI=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=d5XG82UY6SuEuCJjAEvsHAtQj5KVJmGjDRm67LRlLsEQVU0coO8nPlr7cCcsNfijV KIIcTzBWhyNpktvKPRTwFcxeXH87ICWUnUwwWESn7Oagi2eqXEa+5HznWESFMyhgoe XDg4qLERsDqucpoZgkyXxBnqvbhUP5YgivRKh+t0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 87C30F80217; Mon, 27 Apr 2020 16:05:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BC1E4F8022B; Mon, 27 Apr 2020 16:05:45 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 05C7EF80113 for ; Mon, 27 Apr 2020 16:05:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 05C7EF80113 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id DA3D2AB91; Mon, 27 Apr 2020 14:05:37 +0000 (UTC) Date: Mon, 27 Apr 2020 16:05:37 +0200 Message-ID: From: Takashi Iwai To: Pavel Hofman Subject: Re: High-bandwidth/multiple transactions per microframe in usb audio? In-Reply-To: References: <548c8312bd8ad65993c3169faf30054fdfa83558.camel@tsoy.me> <3a44ca23-f0ed-af54-3e63-8bf77d833c8f@ivitera.com> <253259a4ef8a2bcfa0568982b8fd23d5e2d0937a.camel@tsoy.me> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Alexander Tsoy , "alsa-devel@alsa-project.org" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 26 Apr 2020 10:55:32 +0200, Pavel Hofman wrote: > > Dne 25. 04. 20 v 21:50 Alexander Tsoy napsal(a): > > В Сб, 25/04/2020 в 20:06 +0200, Pavel Hofman пишет: > > > > And I just noticed that USB-audio driver can't properly parse max > > packet size for SuperSpeed and SuperSpeed+ devices yet. See > > audio_format_alloc_init(). > > Very good catch. IIUC there are two basically equivalent calculations > for HighSpeed - > > https://elixir.bootlin.com/linux/v5.6.7/source/drivers/usb/core/urb.c#L445 > > > https://elixir.bootlin.com/linux/v5.6.7/source/sound/usb/stream.c#L691 > > > And audio_format_alloc_init missing the sections for SS, SS+ in > usb_submit_urb . Perhpas a common method to make the calculation for all > cases would make it more robust? Yes, a common USB helper function sounds like a good idea. thanks, Takashi